Don't initialize the StackTraceExplorer tool window until it is invoked#60973
Merged
ryzngard merged 1 commit intodotnet:mainfrom Apr 27, 2022
Merged
Don't initialize the StackTraceExplorer tool window until it is invoked#60973ryzngard merged 1 commit intodotnet:mainfrom
ryzngard merged 1 commit intodotnet:mainfrom
Conversation
davidwengier
approved these changes
Apr 27, 2022
Contributor
|
@ryzngard we should port this to 17.3.Preview1 |
ryzngard
added a commit
to ryzngard/roslyn
that referenced
this pull request
Apr 27, 2022
…ed (dotnet#60973) Fixes AB#1524181 Tested locally and command invocation works as expected. The initialization was causing package loads while the Roslyn package was initializing. We can wait until needed, and likely those packages are loaded by then anyways.
ryzngard
added a commit
to ryzngard/roslyn
that referenced
this pull request
Apr 27, 2022
…ed (dotnet#60973) Fixes AB#1524181 Tested locally and command invocation works as expected. The initialization was causing package loads while the Roslyn package was initializing. We can wait until needed, and likely those packages are loaded by then anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#1524181
Tested locally and command invocation works as expected. The initialization was causing package loads while the Roslyn package was initializing. We can wait until needed, and likely those packages are loaded by then anyways.