Skip to content

Merge release/dev17.2 to main#60877

Merged
dotnet-bot merged 5 commits intomainfrom
merges/release/dev17.2-to-main
Apr 21, 2022
Merged

Merge release/dev17.2 to main#60877
dotnet-bot merged 5 commits intomainfrom
merges/release/dev17.2-to-main

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is an automatically generated pull request from release/dev17.2 into main.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/release/dev17.2-to-main
git reset --hard upstream/main
git merge upstream/release/dev17.2
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.2-to-main --force

CyrusNajmabadi and others added 3 commits April 19, 2022 17:00
Revert "Don't complete quotes if they complete a valid string (#60227)"
* Add an aggregate logger for inheritance margin

* Fix a typo
@dotnet-bot dotnet-bot requested a review from a team as a code owner April 21, 2022 06:02
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Apr 21, 2022
@dotnet-bot
Copy link
Copy Markdown
Collaborator Author

⚠ This PR has merge conflicts. @dibarbet

@dotnet-bot dotnet-bot enabled auto-merge April 21, 2022 06:02
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@dotnet-bot dotnet-bot force-pushed the merges/release/dev17.2-to-main branch from a6b2e71 to 432d17a Compare April 21, 2022 06:02
@dibarbet dibarbet removed the Merge Conflicts There are merge conflicts with the base branch. label Apr 21, 2022
@dotnet-bot dotnet-bot merged commit 98ebada into main Apr 21, 2022
@ghost ghost added this to the Next milestone Apr 21, 2022
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants