Revert "Don't complete quotes if they complete a valid string (#60227)"#60851
Merged
CyrusNajmabadi merged 1 commit intodotnet:release/dev17.2from Apr 20, 2022
Merged
Conversation
Contributor
|
cc @davidwengier for info |
dibarbet
approved these changes
Apr 20, 2022
dibarbet
approved these changes
Apr 20, 2022
genlu
approved these changes
Apr 20, 2022
Member
|
Whoops! Thanks |
Contributor
Author
|
Preemptively merging after convo with @jinujoseph . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#1525830
This reverts commit a838dcf.
That PR (AB#1525830) introduced a hang. We will reintroduce this back in 17.3 with the hang fixed.