Skip to content

Change ServiceHub host names#60778

Merged
genlu merged 2 commits intodotnet:main-vs-depsfrom
genlu:ChangeHostName
Jul 18, 2022
Merged

Change ServiceHub host names#60778
genlu merged 2 commits intodotnet:main-vs-depsfrom
genlu:ChangeHostName

Conversation

@genlu
Copy link
Copy Markdown
Member

@genlu genlu commented Apr 15, 2022

Reacting to incoming breaking change from ServiceHub. Can't merge until all services running in our host are migrated and a coordinated insertion is probably needed to avoid disruption.

@NTaylorMullen @y87feng @vivlimmsft @RyanToth3
FYI @dibarbet for Roslyn infra

Validation insertion: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/396138

Razor PR: dotnet/razor#6292 dotnet/razor#6562
pythia: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/Pythia/pullrequest/404615
unittest: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/VSUnitTesting/pullrequest/394614

@ghost ghost added the Area-Infrastructure label Apr 15, 2022
@vivlimmsft
Copy link
Copy Markdown
Contributor

looping in @DavidObando who's making the change for Pythia

@genlu genlu marked this pull request as ready for review May 12, 2022 20:48
@genlu genlu requested a review from a team as a code owner May 12, 2022 20:48
@genlu genlu changed the base branch from main to main-vs-deps June 9, 2022 17:58
@genlu
Copy link
Copy Markdown
Member Author

genlu commented Jun 9, 2022

Targets main-vs-deps since the ServiceHub 4.0 bits are not in 17.3P1

dartlab integration test valdiation
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6397700&view=results

Copy link
Copy Markdown
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @dibarbet for Roslyn infra

tagging @RikkiGibson as the current tiger

@dibarbet dibarbet requested a review from RikkiGibson June 9, 2022 18:11
Copy link
Copy Markdown
Member

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for heads up. It sounds like @genlu will coordinate here. Let's just make sure we know who our contacts are for each of the affected teams and that they either have SHAs for us to cherry-pick or they are on track to produce such SHAs.

@genlu genlu changed the base branch from main-vs-deps to main July 6, 2022 18:46
@genlu genlu force-pushed the ChangeHostName branch 3 times, most recently from 92a9f66 to 2afffab Compare July 6, 2022 19:10
@genlu genlu requested a review from a team as a code owner July 11, 2022 20:19
@genlu genlu changed the base branch from main to main-vs-deps July 11, 2022 20:19
@genlu genlu merged commit a952091 into dotnet:main-vs-deps Jul 18, 2022
@genlu genlu deleted the ChangeHostName branch July 18, 2022 18:43
@ghost ghost added this to the Next milestone Jul 18, 2022
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants