Skip to content

Migrate to changed ServiceHub host names.#6292

Merged
NTaylorMullen merged 1 commit intomainfrom
nimullen/servicehubchanges
Jun 9, 2022
Merged

Migrate to changed ServiceHub host names.#6292
NTaylorMullen merged 1 commit intomainfrom
nimullen/servicehubchanges

Conversation

@NTaylorMullen
Copy link
Copy Markdown

  • Asked to change the name

/cc @genlu Here's our reaction to the announcement. Nothing works because it's not inserted yet + I'm not sure if it'll even work until Roslyn reacts. Thought I'd ping you either way

@genlu
Copy link
Copy Markdown
Member

genlu commented Apr 14, 2022

Thanks! I just sent you an email about this. I believe this requires Roslyn to make the same change to work. Given that (1) the servicehub change isn't inserted yet and (2) there are more services hosted in Roslyn's process. Let's wait until next week to start the work for a coordinated change/insertion.

Also, you might want to bump the servicehub reference to 4.0 as they asked too.

- Asked to change the name
@NTaylorMullen NTaylorMullen force-pushed the nimullen/servicehubchanges branch from 8372230 to c8b85ba Compare May 2, 2022 20:49
@NTaylorMullen NTaylorMullen marked this pull request as ready for review June 8, 2022 20:49
@NTaylorMullen
Copy link
Copy Markdown
Author

@dotnet/razor-tooling marked this as for review now given all the changes are in VS

Copy link
Copy Markdown
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@NTaylorMullen NTaylorMullen merged commit e5bf29c into main Jun 9, 2022
@NTaylorMullen NTaylorMullen deleted the nimullen/servicehubchanges branch June 9, 2022 16:59
@@ -1,5 +1,5 @@
{
"host": "coreClr",
"host": "dotnet.x64",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like ServiceHub have tweaked the host name, and we can simply use dotnet . I will clearify with themhttps://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/27954/ServiceHub-Host-configurations?anchor=hosts-to-be-deprecated-soon

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting

@@ -1,5 +1,5 @@
{
"host": "desktopClr.x86",
"host": "netfx.x86",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete the 32bit config now. Roslyn no longer ships it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants