Update Typescript VS interface#60635
Merged
dibarbet merged 4 commits intodotnet:release/dev17.2from Apr 9, 2022
Merged
Conversation
dibarbet
reviewed
Apr 7, 2022
src/Features/Core/Portable/ExternalAccess/VSTypeScript/Api/VSTypeScriptCompletionProvider.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 7, 2022
src/Features/Core/Portable/ExternalAccess/VSTypeScript/Api/VSTypeScriptCompletionProvider.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 7, 2022
.../Core/Portable/ExternalAccess/VSTypeScript/Api/VSTypeScriptCompletionServiceWithProviders.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 7, 2022
src/Features/Core/Portable/ExternalAccess/VSTypeScript/Api/VSTypeScriptCompletionProvider.cs
Show resolved
Hide resolved
MariaSolOs
commented
Apr 7, 2022
|
|
||
| internal sealed override bool ShouldTriggerCompletion(HostLanguageServices languageServices, SourceText text, int caretPosition, CompletionTrigger trigger, CompletionOptions options, OptionSet passThroughOptions) | ||
| => ShouldTriggerCompletionImpl(text, caretPosition, trigger, options.TriggerOnTypingLetters); | ||
| { |
Contributor
Author
There was a problem hiding this comment.
We only need to trigger the completion of non-expanded items.
Contributor
Author
There was a problem hiding this comment.
Turns out that we didn't need to make any changes here and just verify that the correct GetCompletions method is invoked. Functioning locally and doesn't require any changes in the TypeScript side.
tmat
approved these changes
Apr 7, 2022
|
|
MariaSolOs
commented
Apr 8, 2022
| return base.GetBetterItem(item, existingItem); | ||
| } | ||
|
|
||
| internal override Task<CompletionList> GetCompletionsAsync( |
Contributor
Author
There was a problem hiding this comment.
Removing this method since it's now overridden by the parent class.
dibarbet
added a commit
that referenced
this pull request
Apr 13, 2022
* Update versions for preview 4 * Update Typescript VS interface (#60635) * Update Typescript VS interface * Restore method signatures in completion provider * Move completion override to completion service with providers * Remove duplicate override Co-authored-by: Maria Solano <mariasolano@microsoft.com> Co-authored-by: David Barbet <dabarbet@microsoft.com> Co-authored-by: Joey Robichaud <jorobich@microsoft.com> Co-authored-by: Maria José Solano <majosolano99@gmail.com> Co-authored-by: Maria Solano <mariasolano@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompletionOptionsaren't correctly passed to TypeScript in Visual Studio, causing duplications in the completion list. This PR updates the relevant interfaces so that theCompletionProvidersare correctly invoked.