[main] Update dependencies from dotnet/arcade by dotnet-maestro[bot] · Pull Request #60523 · dotnet/roslyn

dotnet-maestro · 2022-04-01T12:21:11Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: 7e4fe80a-482b-4a41-5b66-08d8d8feb47e
Build: 20220415.2
Date Produced: April 16, 2022 2:47:34 AM UTC
Commit: 4000024394df3049886c50e54ad0a2b903221ef0
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.Arcade.Sdk: from 7.0.0-beta.22179.1 to 7.0.0-beta.22215.2
- Microsoft.DotNet.Helix.Sdk: from 7.0.0-beta.22179.1 to 7.0.0-beta.22215.2

…331.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22181.2

ghost

This PR changes the .NET SDK version. Review required from @dotnet/roslyn-infrastructure before merging.
Tasks:

Getting Started Documentation has been updated
NuGet dependency version updated to match version shipping in SDK

…406.10 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22206.10

…411.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22211.6

…412.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22212.2

…83d6-461c-9be0-5a7df61c07f0

…413.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22213.2

docs/contributing/Building, Debugging, and Testing on Unix.md

docs/contributing/Building, Debugging, and Testing on Windows.md

dibarbet · 2022-04-14T20:29:54Z

@dotnet/roslyn-compiler - there are a few compiler tests failing with the upgrade to .net7, some potentially related to the runtime change of looking up enum members. Could someone take a look at those tests?

@jasonmalinowski / @chsienki - there is a correctness failure I think related to source generators

##[error]src\Compilers\Test\Core\ModuleInitializer.cs(15,10): error CA2255: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'ModuleInitializer' attribute is only intended to be used in application code or advanced source generator scenarios

Could one of you advise on the correct fix there?

Co-authored-by: Joey Robichaud <jorobich@microsoft.com>

jasonmalinowski · 2022-04-14T20:33:08Z

@dibarbet: it looks like that's not really generator related, but rather some analyzer is now telling us not to do what we do here:

roslyn/src/Compilers/Test/Core/ModuleInitializer.cs

Lines 15 to 20 in b922e70

    
           [ModuleInitializer] 
        
           internal static void Initialize() 
        
           { 
        
               Trace.Listeners.Clear(); 
        
               Trace.Listeners.Add(new ThrowingTraceListener()); 
        
           }

Right fix is probably just to #pragma suppress that.

AlekseyTs · 2022-04-14T20:50:26Z

@dibarbet

Could someone take a look at those tests?

Where are the details about the failures?

dibarbet · 2022-04-14T21:14:09Z

@AlekseyTs apologies - my commit triggered a rerun - the test failures should be appearing now.

E.g. (just one example, there are more failures, see the tests tab on ADO)
https://dev.azure.com/dnceng/public/_build/results?buildId=1717786&view=ms.vss-test-web.build-test-results-tab&runId=46664704&resultId=151848&paneView=debug

Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols.Source.EnumTests.ConvertOnEnum
Roslyn.Test.Utilities.ExecutionException :
Execution failed for assembly '86534577-d1f7-47d9-9e2b-9d3065a73668, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'.
Expected:
ValueE
-1

Actual: ValueB
-1

AlekseyTs · 2022-04-14T21:32:57Z

For compiler tests, I suggest:

updating baselines for tests that fail due to a baseline diff and opening an issue to follow up/confirm the change.
disabling tests that fail due to other reasons and opening an issue to follow up.

dibarbet · 2022-04-14T21:36:51Z

For compiler tests, I suggest:

updating baselines for tests that fail due to a baseline diff and opening an issue to follow up/confirm the change.

disabling tests that fail due to other reasons and opening an issue to follow up.

Thanks - will do!

…414.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22214.3

src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs

src/Compilers/CSharp/Test/Symbol/Symbols/Source/EnumTests.cs

src/Compilers/Core/CodeAnalysisTest/CorLibTypesTests.cs

src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs

…415.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22215.1

…415.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22215.2

no longer applicable, updated docs

Update dependencies from https://github.com/dotnet/arcade build 20220…

75d10a7

…331.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22181.2

dotnet-maestro bot requested a review from a team as a code owner April 1, 2022 12:21

ghost previously requested changes Apr 1, 2022

View reviewed changes

ghost added the Area-Infrastructure label Apr 1, 2022

dotnet-maestro bot added 2 commits April 8, 2022 12:21

Update dependencies from https://github.com/dotnet/arcade build 20220…

f8abf09

…406.10 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22206.10

Update dependencies from https://github.com/dotnet/arcade build 20220…

e840cbd

…411.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22211.6

runfoapp bot mentioned this pull request Apr 12, 2022

Timeout on Microsoft.VisualStudio.LanguageServices.CSharp.UnitTests.dll tests #55638

Open

Update dependencies from https://github.com/dotnet/arcade build 20220…

97304bb

…412.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22212.2

runfoapp bot mentioned this pull request Apr 13, 2022

VSTypeScriptHandlerTests flaky #60694

Closed

dibarbet and others added 4 commits April 13, 2022 15:14

Merge remote-tracking branch 'upstream/main' into darc-main-7af0f9af-…

0b08e34

…83d6-461c-9be0-5a7df61c07f0

Update analyzer version

d9748a6

Update nuget common version and docs for .net7

5fe2523

Update dependencies from https://github.com/dotnet/arcade build 20220…

8a45acf

…413.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22213.2

JoeRobich reviewed Apr 14, 2022

View reviewed changes

docs/contributing/Building, Debugging, and Testing on Unix.md Outdated Show resolved Hide resolved

docs/contributing/Building, Debugging, and Testing on Windows.md Outdated Show resolved Hide resolved

Apply suggestions from code review

d3d0c83

Co-authored-by: Joey Robichaud <jorobich@microsoft.com>

This was referenced Apr 15, 2022

Renable TestGeneratorsCantTargetNetFramework #60762

Open

Reenable AssemblyLoading_MultipleVersions_ExactAndGreaterMatch #60763

Closed

Disable and update compiler tests for .net7

3c25e89

dotnet-maestro bot requested a review from a team as a code owner April 15, 2022 01:15

Update dependencies from https://github.com/dotnet/arcade build 20220…

3557e56

…414.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22214.3

dibarbet added 2 commits April 15, 2022 11:22

Fix tests to assert right condition if targeting .net framework

7d1e43c

Fix formatting warnings

7564db8

JoeRobich reviewed Apr 15, 2022

View reviewed changes

src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs Show resolved Hide resolved

JoeRobich reviewed Apr 15, 2022

View reviewed changes

src/Compilers/CSharp/Test/Symbol/Symbols/Source/EnumTests.cs Outdated Show resolved Hide resolved

JoeRobich reviewed Apr 15, 2022

View reviewed changes

src/Compilers/Core/CodeAnalysisTest/CorLibTypesTests.cs Show resolved Hide resolved

feedback

0f277c8

JoeRobich reviewed Apr 16, 2022

View reviewed changes

Fix formatting

6c2feb7

JoeRobich approved these changes Apr 16, 2022

View reviewed changes

dotnet-maestro bot added 2 commits April 16, 2022 12:22

Update dependencies from https://github.com/dotnet/arcade build 20220…

5b4b59d

…415.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22215.1

Update dependencies from https://github.com/dotnet/arcade build 20220…

dde0db4

…415.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.22179.1 -> To Version 7.0.0-beta.22215.2

dibarbet merged commit 3c00d86 into main Apr 19, 2022

dibarbet deleted the darc-main-7af0f9af-83d6-461c-9be0-5a7df61c07f0 branch April 19, 2022 01:06

ghost added this to the Next milestone Apr 19, 2022

dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022

JoeRobich added a commit that referenced this pull request May 2, 2022

Backport test fixes from #60523

971d47b

JoeRobich added a commit that referenced this pull request Jul 5, 2022

Revert ShadowCopyAnalyzerAssemblyLoaderTests change from #60523

e835d2e

JoeRobich added a commit that referenced this pull request Jul 5, 2022

Revert ShadowCopyAnalyzerAssemblyLoaderTests change from #60523

d5f9334

ryzngard mentioned this pull request Jul 27, 2022

Enable new inline rename by default #62992

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/arcade#60523

[main] Update dependencies from dotnet/arcade#60523
dibarbet merged 17 commits intomainfrom
darc-main-7af0f9af-83d6-461c-9be0-5a7df61c07f0

dotnet-maestro bot commented Apr 1, 2022 •

edited

Loading

Uh oh!

ghost left a comment

Uh oh!

Uh oh!

Uh oh!

dibarbet commented Apr 14, 2022

Uh oh!

jasonmalinowski commented Apr 14, 2022

Uh oh!

AlekseyTs commented Apr 14, 2022

Uh oh!

dibarbet commented Apr 14, 2022 •

edited

Loading

Uh oh!

AlekseyTs commented Apr 14, 2022

Uh oh!

dibarbet commented Apr 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dotnet-maestro bot commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/arcade

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dibarbet commented Apr 14, 2022

Uh oh!

jasonmalinowski commented Apr 14, 2022

Uh oh!

AlekseyTs commented Apr 14, 2022

Uh oh!

dibarbet commented Apr 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlekseyTs commented Apr 14, 2022

Uh oh!

dibarbet commented Apr 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dotnet-maestro bot commented Apr 1, 2022 •

edited

Loading

dibarbet commented Apr 14, 2022 •

edited

Loading