Skip to content

Remove enableRoslynAnalyzers from codespace default settings#60203

Merged
JoeRobich merged 1 commit intomainfrom
dev/jmarolf/infrastructure/remove-enableRoslynAnalyzers-settings-in-codespace
Mar 23, 2022
Merged

Remove enableRoslynAnalyzers from codespace default settings#60203
JoeRobich merged 1 commit intomainfrom
dev/jmarolf/infrastructure/remove-enableRoslynAnalyzers-settings-in-codespace

Conversation

@jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Mar 16, 2022

Follow up to #60165

We don't think this is the right default as users probably don't want this unless they have at least 8 cores.

Follow up to #60165

We don't think this is the right default as users probably don't want this unless they have at least 8 cores.
@ghost ghost added the Area-Infrastructure label Mar 16, 2022
@jmarolf jmarolf requested review from a team and RikkiGibson March 16, 2022 20:41
@jmarolf jmarolf enabled auto-merge March 16, 2022 20:41
@RikkiGibson
Copy link
Member

FWIW, I have 12 cores and the editor completely falls over in NullableReferenceTypesTests when this setting is enabled.

@jmarolf
Copy link
Contributor Author

jmarolf commented Mar 22, 2022

/azp run roslyn-integration-corehost

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoeRobich JoeRobich disabled auto-merge March 23, 2022 00:07
@JoeRobich JoeRobich merged commit 70c3f1b into main Mar 23, 2022
@ghost ghost added this to the Next milestone Mar 23, 2022
@JoeRobich
Copy link
Member

Non-functional change shouldn't require CI. Jon opened #60327 to fix going forward.

@333fred 333fred deleted the dev/jmarolf/infrastructure/remove-enableRoslynAnalyzers-settings-in-codespace branch March 23, 2022 00:23
@allisonchou allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants