Analyze flow in receiver of extension method group in delegate creation#59874
Merged
RikkiGibson merged 3 commits intodotnet:mainfrom Mar 8, 2022
Merged
Analyze flow in receiver of extension method group in delegate creation#59874RikkiGibson merged 3 commits intodotnet:mainfrom
RikkiGibson merged 3 commits intodotnet:mainfrom
Conversation
RikkiGibson
approved these changes
Mar 2, 2022
Member
Author
|
@dotnet/roslyn-compiler for second review. Thanks |
1 similar comment
Member
Author
|
@dotnet/roslyn-compiler for second review. Thanks |
cston
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59738
Below is the current behavior of a test that illustrates the problem. The problem occurs when creating a delegate with a method group, using an extension method. In such case, we fail to visit the receiver of the extension method.
Note that local function invocations can have a receiver (implicit
this) so the local function case was moved to be handled first.The behavior in the reported issue also results from our not visiting the receiver. The analysis keeps track of when we enter/exit the region marked with
/*<bind>*/and since we didn't visit the expression, the state of the visitor was stuck on "before" which results in a failed analysis.Co-Authored-By: Bernd Baumanns baumannsbernd@gmail.com