Add basic TS LSP server by dibarbet · Pull Request #59639 · dotnet/roslyn

dibarbet · 2022-02-18T02:22:59Z

Adds a typescript LSP server to roslyn. This does 2 things for us-

We can move features to LSP (using a roslyn implementation) without being blocked on typescript. The first example of this is in the PR - pull diagnostics.
Also allows typescript to create their own LSP handler implementations that use the correct LSP queueing and snapshot tracking mechanism that we've made. Their current LSP server implementation relies on workspace.CurrentSolution to retrieve document text which is not correct.

The long term goal is for typescript to entirely switch to tsserver at which point this will no longer be needed, but that is not doable at this time.

The process in this PR is to implement external access for the IRequestHandler types in Roslyn, without coupling typescript to our specific LSP protocol dll implementation. #59510 allows us to use runtime type arguments for handlers, this exposes an external access API around creating request handlers and providing server capabilities.

PR val - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/383523
TS example usage - https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/commit/afbedc3b6e91428da288e6f454b1d477e196d1d6?refName=refs/heads/dev/dabarbet/lsp_example&path=/VS/LanguageService/TypeScriptLanguageService/LSP/Hover

dibarbet · 2022-03-04T00:28:41Z

src/EditorFeatures/Core/ExternalAccess/VSTypeScript/VSTypeScriptInProcLanguageClient.cs

+
+        public override ServerCapabilities GetCapabilities(ClientCapabilities clientCapabilities)
+        {
+            var serverCapabilities = GetTypeScriptServerCapabilities(clientCapabilities);


we combine any capabilities that ts provided via external access with the capabilities we wish to turn on from roslyn handlers.

dibarbet · 2022-03-04T00:29:25Z

src/EditorFeatures/Core/ExternalAccess/VSTypeScript/VSTypeScriptInProcLanguageClient.cs

+            {
+                var serializedClientCapabilities = JsonConvert.SerializeObject(clientCapabilities);
+                var serializedServerCapabilities = _typeScriptCapabilitiesProvider.GetServerCapabilities(serializedClientCapabilities);
+                var typeScriptServerCapabilities = JsonConvert.DeserializeObject<VSInternalServerCapabilities>(serializedServerCapabilities);


talk in terms of serialized capabilities to avoid hard dependencies on protocol types

dibarbet · 2022-03-04T00:30:08Z

src/Features/LanguageServer/ProtocolUnitTests/VSTypeScriptHandlerTests.cs

+
+    internal record TSRequest(Uri Document, string Project);
+
+    [VSTypeScriptMethod(MethodName)]


this and below is an example of how the external access api is used

…red-members * upstream/main: (50 commits) Fix top-level speculation (dotnet#60274) Skip CodeDefinitionWindows integration tests Avoid resizing array builder while get unaliased references (dotnet#60220) Fix our x86 test execution (dotnet#60323) [LSP] Don't adjust breakpoints when there are diagnostics in the document (dotnet#60334) Allow VS Mac to access a few options and a helper method (dotnet#60333) Add support for CheckedStatement for smart break line (dotnet#60308) Initialize MEF parts before switching to the UI thread (dotnet#60289) Don't offer convert to switch when an implicit cast is present (dotnet#60224) Fix Add basic TS LSP server (dotnet#59639) Fix issue when multiple different diagnostics share a single fixer Update dependencies from https://github.com/dotnet/arcade build 20220321.2 (dotnet#60315) Check for reference assembly before deciding which language to show (dotnet#60271) Fix XLF files that were manually edited Revert "Fix a typo and an inconsistency" Fix conversion issues in null coalescing operator (dotnet#60202) Fix type parameter scoping for local functions (dotnet#60098) Update SDK version in docs, etc. (dotnet#60299) Edit the breaking change doc for publishing on docs (dotnet#60260) ...

* Create solution on the main thread in integration tests * Close solution on the main thread in integration tests * Use cached data for completion of unimported types Even if it might be stale. the completion list would be computed with cached data and cache refresh would be done in background. * Use cached data for completion of unimported extension methods Even if it might be stale. the completion list would be computed with cached data and cache refresh would be done in background. * Try to refresh import completion cache in the background whenever completion is triggered * Use AsyncBatchingWorkQueue for background cache updates * Fix tests * clean up * Fix tests * Make sure background task to update cache always run * Expose ForceExpandedCompletionIndexCreation option to O# This can be used to tweak test behavior to make it deterministic * Don't use Workspace.CurrentSolution when refreshing cache in background * Use AsynchronousOperationListener for background workqueues * Update src/Tools/ExternalAccess/OmniSharp/Completion/OmniSharpCompletionOptions.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> * Pass ThreadingContext.DisposalToken to workqueue for cache refresh * Remove namespace imports * Remove enableRoslynAnalyzers from codespace default settings Follow up to #60165 We don't think this is the right default as users probably don't want this unless they have at least 8 cores. * Fix typo in Apply_namespace_matches_folder_preferences * Remove period at the end to be consistent with other messages * Fix inconsistency in other languages too * Refactoring * Ban incompatible service provider extension methods * Assert window title before closing * Remove outdated comment (#60275) * Don't block on clearing the output window on the UI thread when generating a file (#60281) * Fix issue with remove-unnecessary-cast and necessary explicit casts. * Fix work item * Correct change ObjectCreationExpression to ImplictObjectCreationExpression for SmartBreakline (#60249) * Fix the initializer adding scenario * Fix the initializer removal scenario * Add an Assertion in debug to help if future derive type is added * Remove the check for NewKeyword * Option to always use default symbol servers for GTD (#60053) * pass the listener to the constructor * Edit the breaking change doc for publishing on docs (#60260) Co-authored-by: Rikki Gibson <rikkigibson@gmail.com> * Update SDK version in docs, etc. (#60299) * Fix type parameter scoping for local functions (#60098) Co-authored-by: Youssef1313 <youssefvictor00@gmail.com> * Fix conversion issues in null coalescing operator (#60202) * Revert "Fix a typo and an inconsistency" This reverts #60238 * Fix XLF files that were manually edited * Check for reference assembly before deciding which language to show (#60271) * Update dependencies from https://github.com/dotnet/arcade build 20220321.2 (#60315) [main] Update dependencies from dotnet/arcade * Fix issue when multiple different diagnostics share a single fixer * Add basic TS LSP server (#59639) * Add basic TS LSP server * Add external access layer for TS * Include text sync handlers * Fix build error * Switch to explicit interface impl * Fix namespaces * Remove testing string * Fix * Don't offer convert to switch when an implicit cast is present (#60224) * Initialize MEF parts before switching to the UI thread (#60289) * Add support for CheckedStatement for smart break line (#60308) * Add support for CheckedStatement * Address feedback * Remove a not needed import * Allow VS Mac to access a few options and a helper method (#60333) * [LSP] Don't adjust breakpoints when there are diagnostics in the document (#60334) * Fix our x86 test execution (#60323) * Fix our x86 test execution The transition to `dotnet test` seems to have broken our unit tests that depend on executing on an x86 architecture. This fixes that by using the `--arch` argument to the `dotnet test` execution. This was made more general to facilitate our future arm64 work in this area * Disable test failing on x64 * fix the test * Apply suggestions from code review Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> * Disable test on spanish * Test fixes Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> * Avoid resizing array builder while get unaliased references (#60220) This was being resized constantly after opening Orchard Core, allocating about 2 GB. The fact that is being called this many times appears to be another bug that I'm following up on. * Skip CodeDefinitionWindows integration tests * Fix top-level speculation (#60274) Co-authored-by: Youssef Victor <youssefvictor00@gmail.com> Co-authored-by: Sam Harwell <Sam.Harwell@microsoft.com> Co-authored-by: gel@microsoft.com <gel@microsoft.com> Co-authored-by: Gen Lu <genlu@users.noreply.github.com> Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> Co-authored-by: Jonathon Marolf <jmarolf@users.noreply.github.com> Co-authored-by: Daniel Chalmers <daniel.chalmers@outlook.com> Co-authored-by: astroC86 <66444189+astroC86@users.noreply.github.com> Co-authored-by: David Wengier <david.wengier@microsoft.com> Co-authored-by: Cyrus Najmabadi <cyrusn@microsoft.com> Co-authored-by: Shen Chen <Cosifne@users.noreply.github.com> Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Co-authored-by: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Co-authored-by: Bill Wagner <wiwagn@microsoft.com> Co-authored-by: Rikki Gibson <rikkigibson@gmail.com> Co-authored-by: Rikki Gibson <rigibson@microsoft.com> Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com> Co-authored-by: Youssef1313 <youssefvictor00@gmail.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Joey Robichaud <jorobich@microsoft.com> Co-authored-by: David Barbet <dabarbet@microsoft.com> Co-authored-by: Jared Parsons <jaredpparsons@gmail.com> Co-authored-by: David Kean <davkean@microsoft.com>

Add basic TS LSP server

f89cdd4

ghost added the Area-IDE label Feb 18, 2022

Merge remote-tracking branch 'upstream/main' into ts_lsp

9fcd05c

runfoapp bot mentioned this pull request Feb 28, 2022

Timeout on Microsoft.VisualStudio.LanguageServices.CSharp.UnitTests.dll tests #55638

Open

dibarbet added 2 commits March 2, 2022 17:22

Add external access layer for TS

fb78f31

Include text sync handlers

3b39931

dibarbet force-pushed the ts_lsp branch from 5324c29 to 3b39931 Compare March 3, 2022 02:22

dibarbet added 4 commits March 2, 2022 18:41

Fix build error

20ac7b2

Switch to explicit interface impl

afb6d94

Fix namespaces

f89f851

Remove testing string

c39bfec

dibarbet added the LSP issues related to the roslyn language server protocol implementation label Mar 4, 2022

Merge remote-tracking branch 'upstream/main' into ts_lsp

926b74c

dibarbet marked this pull request as ready for review March 4, 2022 00:27

dibarbet requested a review from a team as a code owner March 4, 2022 00:27

dibarbet commented Mar 4, 2022

View reviewed changes

dibarbet mentioned this pull request Mar 8, 2022

Add VS typescript access to LSP #58777

Closed

Merge remote-tracking branch 'upstream/main' into ts_lsp

ab4bb4e

davidwengier approved these changes Mar 21, 2022

View reviewed changes

dibarbet merged commit 38913c8 into dotnet:main Mar 22, 2022

dibarbet deleted the ts_lsp branch March 22, 2022 17:34

ghost added this to the Next milestone Mar 22, 2022

333fred mentioned this pull request Mar 24, 2022

Merge main to features/required-members #60373

Merged

allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic TS LSP server#59639

Add basic TS LSP server#59639
dibarbet merged 10 commits intodotnet:mainfrom
dibarbet:ts_lsp

dibarbet commented Feb 18, 2022 •

edited

Loading

Uh oh!

dibarbet Mar 4, 2022

Uh oh!

dibarbet Mar 4, 2022

Uh oh!

dibarbet Mar 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		internal record TSRequest(Uri Document, string Project);

		[VSTypeScriptMethod(MethodName)]

Conversation

dibarbet commented Feb 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dibarbet Mar 4, 2022

Choose a reason for hiding this comment

Uh oh!

dibarbet Mar 4, 2022

Choose a reason for hiding this comment

Uh oh!

dibarbet Mar 4, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dibarbet commented Feb 18, 2022 •

edited

Loading