Pass exception into internal error diagnostic#59443
Merged
davidwengier merged 6 commits intodotnet:mainfrom Feb 14, 2022
Merged
Pass exception into internal error diagnostic#59443davidwengier merged 6 commits intodotnet:mainfrom
davidwengier merged 6 commits intodotnet:mainfrom
Conversation
Youssef1313
reviewed
Feb 10, 2022
Member
Youssef1313
left a comment
There was a problem hiding this comment.
Note: the failing test is culture-sensitive. Adding the whole message in English will fail Spanish test run.
Youssef1313
reviewed
Feb 11, 2022
src/EditorFeatures/TestUtilities/EditAndContinue/RudeEditDiagnosticDescription.cs
Show resolved
Hide resolved
Youssef1313
approved these changes
Feb 11, 2022
Member
Author
|
@tmat PTAL |
tmat
approved these changes
Feb 14, 2022
333fred
added a commit
that referenced
this pull request
Feb 15, 2022
…ures/required-members * upstream/main: (1291 commits) Revert "Make solution options global (#59168)" (#59537) Update src/VisualStudio/CSharp/Test/F1Help/F1HelpTests.cs Update src/VisualStudio/CSharp/Impl/LanguageService/CSharpHelpContextService.cs Update Language Feature Status.md (#59546) Catch more exceptions (#59526) Fix Peek Definition for Razor files (#59528) Update OneOffInsertion.ps1 path in 17.0 branch (#59541) Use GetBestTypeByMetadataName in 'use System.HashCode' fixer Pass exception into internal error diagnostic (#59443) Provide f1 help for discards Update src/VisualStudio/Core/Def/SymbolSearch/AbstractDelayStartedService.cs Fix formatting move line Simplify Simplify Fixup Explicitly perform some mef loads in teh background Bump Microsoft.DiaSymReader version for release Remove IBoundSwitchStatement (#59516) Make solution options global (#59168) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59418
Also validates that this issue won't happen again, at least for EnC rude edits. Found one other issue too!