move Microsoft.CodeAnalysis.Remote.ServiceHub.CoreComponents to net6.…#59324
Merged
jmarolf merged 1 commit intodotnet:mainfrom Feb 6, 2022
Conversation
…0-windows this appears to be an error. the tests for this assembly target net6.0-windows
CyrusNajmabadi
approved these changes
Feb 6, 2022
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
How come this isn't a problem in CI?
Contributor
Author
CI does not use un-released versions of nuget. we build and restore against SDK 6.0.100. The place where this breaking change was introduced (NuGet/NuGet.Client#4372) only exists in internal builds of Visual Studio and the .NET SDK. If you are on a public preview build of Visual Studio you are safe. Though eventually this would break CI when we updated our images or the version of the .NET SDK we used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…0-windows
this appears to be an error. the tests for this assembly target net6.0-windows