Skip to content

fix restore on nuget 6.2.0.33#59230

Merged
jmarolf merged 3 commits intodotnet:mainfrom
jmarolf:infrastructure/fix-restore-on-nuget-6.2.0.33
Feb 6, 2022
Merged

fix restore on nuget 6.2.0.33#59230
jmarolf merged 3 commits intodotnet:mainfrom
jmarolf:infrastructure/fix-restore-on-nuget-6.2.0.33

Conversation

@jmarolf
Copy link
Copy Markdown
Contributor

@jmarolf jmarolf commented Feb 3, 2022

In this PR to nuget: NuGet/NuGet.Client#4372 there was a behavior change that causes a series of cascading NU1701 warnings on Roslyn.sln. As soon as our CI updates to a version of nuget that includes this change our build will break.

@jmarolf jmarolf requested a review from JoeRobich February 3, 2022 02:01
@jmarolf jmarolf requested a review from a team as a code owner February 3, 2022 02:01
@ghost ghost added the Area-Infrastructure label Feb 3, 2022
@JoeRobich
Copy link
Copy Markdown
Member

JoeRobich commented Feb 3, 2022

Should we just set the <AssetTargetFallback> to net472 ? Or does that not resolve this issue?

@jmarolf jmarolf enabled auto-merge February 5, 2022 00:43
@jmarolf jmarolf force-pushed the infrastructure/fix-restore-on-nuget-6.2.0.33 branch from 499b849 to cc402a0 Compare February 6, 2022 03:23
@jmarolf
Copy link
Copy Markdown
Contributor Author

jmarolf commented Feb 6, 2022

Should we just set the to net472 ? Or does that not resolve this issue?

@JoeRobich in testing this does not resolve the issue.

@jmarolf jmarolf merged commit ba61aaa into dotnet:main Feb 6, 2022
@ghost ghost added this to the Next milestone Feb 6, 2022
<NoWarn>$(NoWarn);NU1701</NoWarn>

<!-- Opt-in to faster up-to-date check for restore -->
<RestoreUseStaticGraphEvaluation>true</RestoreUseStaticGraphEvaluation>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This no longer works for -a (build with analyzers)?

sharwell added a commit to sharwell/roslyn that referenced this pull request Feb 7, 2022
…ix-restore-on-nuget-6.2.0.33"

This reverts commit ba61aaa, reversing
changes made to 3ee3ad4.
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants