[EnC] Store entire spans instead of line deltas#58831
Merged
davidwengier merged 4 commits intodotnet:mainfrom Jan 21, 2022
Merged
[EnC] Store entire spans instead of line deltas#58831davidwengier merged 4 commits intodotnet:mainfrom
davidwengier merged 4 commits intodotnet:mainfrom
Conversation
Storing the entire span instead of calculating the line delta gives more accurate results where more than just line delta is needed. We instead now calculate the line delta when we need to provide it to the debugger.
Responding to the rename, and the change in debugger display, used for test verification.
Just cleaning things up
ryzngard
approved these changes
Jan 13, 2022
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
I think this looks correct, in as much as I understand EnC code.
Member
Author
You and me both. The only EnC understanding here is knowing what the fix is, and that was provided by @tmat 😛 |
Member
Author
|
Ping @tmat |
Member
|
Looks good, though I think the new test is a bit hard to read. BaseActiveStatementsAndExceptionRegions_WithInitialNonRemappableRegions is similar but using some markers to make it easier to express the edit. |
tmat
approved these changes
Jan 20, 2022
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jan 21, 2022
* upstream/main: (1035 commits) Add missing header Mark IVSTypeScriptFormattingServiceImplementation as optional, but require it in the constructor Fix Go To Base for a symbol with a single metadata location (dotnet#58965) [EnC] Store entire spans instead of line deltas (dotnet#58831) Delete CodeAnalysisRules.ruleset (dotnet#58968) Allow xml docs to still be created when 'emit metadata only' is on. (dotnet#57667) Fix ParseVBErrorOrWarning (dotnet#47833) Update parameter nullability to match implementation Ensure CSharpUseParameterNullCheckingDiagnosticAnalyzer works with nullable parameters Add tests for issues fixed by previous PR (dotnet#58764) Update src/Features/CSharp/Portable/Completion/CompletionProviders/ExplicitInterfaceMemberCompletionProvider.CompletionSymbolDisplay.cs Disallow null checking discard parameters (dotnet#58952) Add extension method Escape type arguments Few fixes Update tests. Add Analyzers layer to CODEOWNERS Add formatting analyzer test for param nullchecking (dotnet#58936) Move reading HideAdvancedMembers option up (dotnet#58747) List patterns: Slice value is assumed to be never null (dotnet#57457) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58179
Bit noisy with the renames, but pretty straightforward over all. Commit by commit might help, but probably won't make a huge difference.