Backport SpillSequence Fix to 17.1#58788
Merged
333fred merged 1 commit intodotnet:release/dev17.1from Jan 21, 2022
Merged
Conversation
…re spilled. (dotnet#58657) Fixes dotnet#58569. (cherry picked from commit f51c1b2)
cston
approved these changes
Jan 11, 2022
Contributor
Member
Author
Contributor
Effectively we don't have any verification that the #58514 is fixed by this PR. I understand that we have a good reason to believe that it is fixed, but still. Perhaps we should port #58764 as well (Do we need a QB approval for test only changes?), or simply include the tests (at least those we have at the moment) in this PR? |
Member
Author
No, we could merge them into this branch without a problem. I could do that, I just didn't think it was worth the extra effort over putting them into |
333fred
added a commit
that referenced
this pull request
Jan 24, 2022
…merges/release/dev17.1-vs-deps-to-main * upstream/release/dev17.1-vs-deps: Cleanup missed suggestion Update src/Workspaces/Core/Portable/Classification/ClassifierHelper.cs SpillSequenceSpiller.Spill - ensure sequences under ref assignments are spilled. (#58657) (#58788) Correctly update the list of generators for a call to WithAnalyzerReferences Rename parameter for what it's actually doing Handle AdditiveSpans in either order Reduce Stack Trace Explorer automatic open behavior scope (#58819) Revert 58892 (#58930) Mark APIs as shipped (#58776) Revert "Merge pull request #57132 from CyrusNajmabadi/branchId3" Fix race in WorkCoordinator when handling document reanalysis Remove unnecessary lock access setting UIContexts in the workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport the fix for #58514 and #58569 to 17.1 for QB mode. QB Bug https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1460611