Revert "Implement GetTypesByMetadataName"#58784
Merged
333fred merged 1 commit intorelease/dev17.1from Jan 11, 2022
Merged
Conversation
This reverts commit fcc0827.
Member
Author
|
@dotnet/roslyn-infrastructure for a review. |
RikkiGibson
approved these changes
Jan 11, 2022
Member
|
@333fred @RikkiGibson Was this the only thing merged that didn't make it in? In the past we've sometimes just done a force push of the release branch to bring it back in sync, which avoids reverts of reverts, but that has it's own fun. |
Member
Author
It is the only thing. |
Member
Author
|
However, given that this has already gone into -vs-deps, I think the cleanest thing is to just merge the revert, then revert the revert in main. |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jan 12, 2022
…pped * upstream/release/dev17.1: Revert "Implement GetTypesByMetadataName (dotnet#58366)" (dotnet#58784)
333fred
added a commit
that referenced
this pull request
Jan 12, 2022
333fred
added a commit
that referenced
this pull request
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't make it in before the 17.1 bar closed. Reverting for 17.1 and we'll revert the revert in main.