Resolve PROTOTYPE comments in param null checking#58324
Merged
jaredpar merged 2 commits intodotnet:features/param-nullcheckingfrom Dec 15, 2021
Merged
Resolve PROTOTYPE comments in param null checking#58324jaredpar merged 2 commits intodotnet:features/param-nullcheckingfrom
jaredpar merged 2 commits intodotnet:features/param-nullcheckingfrom
Conversation
Filed the following issues: - dotnet#58323 - dotnet#58322 - dotnet#58320
Member
Author
|
@RikkiGibson, @dotnet/roslyn-compiler PTAL |
jaredpar
commented
Dec 14, 2021
src/Compilers/CSharp/Test/Syntax/Parsing/DeclarationParsingTests.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
approved these changes
Dec 14, 2021
Member
RikkiGibson
left a comment
There was a problem hiding this comment.
Thanks! Will remember to address the issues by searching for the URL in source.
cston
approved these changes
Dec 14, 2021
Youssef1313
reviewed
Dec 14, 2021
Comment on lines
+317
to
318
| [Fact(Skip = "https://github.com/dotnet/roslyn/issues/58322")] | ||
| public void TestNullCheckedArgListImplementation() |
Member
There was a problem hiding this comment.
In SharpLab param-nullchecking branch, this already generates an error:
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Dec 16, 2021
…rations * upstream/main: (87 commits) Add support for nullable analysis in interpolated string handler constructors (dotnet#57780) Record list-patterns and newlines in interpolations as done (dotnet#58250) Swithc to acquiring the component model on a BG thread. Fix failure to propagate cancellation token [main] Update dependencies from dotnet/arcade (dotnet#58327) Change PROTOTYPE to issue reference (dotnet#58336) Resolve PROTOTYPE comments in param null checking (dotnet#58324) Address various minor param-nullchecking issues (dotnet#58321) Nullable enable GetTypeByMetadataName (dotnet#58317) Support CodeClass2.Parts returning parts in source generated files Allow the FileCodeModel.Parent to be null Ensure the CodeModel tests are using VisualStudioWorkspaceImpl Fix the bad words in TestDeepAlternation Fix regression in Equals/GetHashCode of LambdaSymbol. (dotnet#58247) Support "Enable nullable reference types" from disable keyword Support "Enable nullable reference types" from restore keyword Support "Enable nullable reference types" on the entire directive Add comment Remove descriptor Update src/Workspaces/Remote/ServiceHub/Services/SemanticClassification/RemoteSemanticClassificationService.cs ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filed the following issues: