Merge main to features/rename_ui_rework#58118
Merged
dotnet-bot merged 88 commits intofeatures/rename_ui_reworkfrom Dec 5, 2021
Merged
Merge main to features/rename_ui_rework#58118dotnet-bot merged 88 commits intofeatures/rename_ui_reworkfrom
dotnet-bot merged 88 commits intofeatures/rename_ui_reworkfrom
Conversation
…rusNajmabadi/roslyn into simplifyInterpolationPArsing4
In the synchronous dispose path, we were asserting that the task completed; if it completed due to a fault, we were silently catching that exception. This ensures we propagate the exception. Under no "normal" circumstance we do we expect an exception to throw when a batch is applied, so this is only needed for diagnosing faults.
If we had an analyzer reference being removed and re-added in the same batch, we would throw exceptions. Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1264575
The VisualStudioAnalyzer also pushes load diagnostics to the workspace so failing to do this would mean they stay around.
…on-of-analyzer-in-same-batch Fix removal and addition of analyzer in same batch
Fixes #57825. Relevant spec adjustment dotnet/csharplang#5484.
…ring Fix curly brace and interpolated string
…rsing8 Fix placement of trivia inside an interpolation
[main] Update dependencies from dotnet/arcade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from main into features/rename_ui_rework.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout -t upstream/merges/main-to-features/rename_ui_rework git reset --hard upstream/features/rename_ui_rework git merge upstream/main # Fix merge conflicts git commit git push upstream merges/main-to-features/rename_ui_rework --force