Skip to content

Add scripts to verify if a branch is ready to review#58110

Merged
jmarolf merged 1 commit intodotnet:mainfrom
jmarolf:infrastructure/verify-ready-for-pr-scripts
Dec 4, 2021
Merged

Add scripts to verify if a branch is ready to review#58110
jmarolf merged 1 commit intodotnet:mainfrom
jmarolf:infrastructure/verify-ready-for-pr-scripts

Conversation

@jmarolf
Copy link
Copy Markdown
Contributor

@jmarolf jmarolf commented Dec 4, 2021

Add a script (Verify.cmd on windows and verify.sh on *nix) that can be run so a contributor can check if there are any obvious errors in their branch.

@ghost ghost added the Area-Infrastructure label Dec 4, 2021
@JoeRobich
Copy link
Copy Markdown
Member

Does this report formatting errors?

Copy link
Copy Markdown
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used to type ./build.cmd -a and now I can type ./verify.cmd which is 2 characters less, so I am very grateful for the productivity boost here 😁

@jmarolf
Copy link
Copy Markdown
Contributor Author

jmarolf commented Dec 4, 2021

Does this report formatting errors?

IDE errors are enforced when we run analyzer right? let me check

@jmarolf
Copy link
Copy Markdown
Contributor Author

jmarolf commented Dec 4, 2021

confirmed working:
image

@jmarolf jmarolf merged commit 04dda9f into dotnet:main Dec 4, 2021
@jmarolf jmarolf deleted the infrastructure/verify-ready-for-pr-scripts branch December 4, 2021 17:03
@ghost ghost added this to the Next milestone Dec 4, 2021
@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants