Reference new debugger bits#58051
Merged
davidwengier merged 3 commits intodotnet:release/dev17.1-vs-depsfrom Dec 2, 2021
Merged
Reference new debugger bits#58051davidwengier merged 3 commits intodotnet:release/dev17.1-vs-depsfrom
davidwengier merged 3 commits intodotnet:release/dev17.1-vs-depsfrom
Conversation
This was referenced Dec 1, 2021
0d6eb3e to
00920ea
Compare
Member
Author
|
Waiting for #58062 to merge, then this will be shorter |
…nto debugger services
b2925cb to
ff49044
Compare
Member
Author
|
Okay this has been rebased and is now a sensible PR @jasonmalinowski @ryzngard @jinujoseph this is the last part of the 17.1 P2 work to enable source link |
ryzngard
reviewed
Dec 2, 2021
| var (project, symbol) = await CompileAndFindSymbolAsync(path, Location.OnDisk, Location.OnDisk, metadataSource, c => c.GetMember("C.E")); | ||
| // Ideally we don't want to pass in true for windowsPdb here, and this is supposed to test that the service ignores non-portable PDBs when the debugger | ||
| // tells us they're not portable, but the debugger has a bug at the moment. | ||
| var (project, symbol) = await CompileAndFindSymbolAsync(path, Location.OnDisk, Location.OnDisk, metadataSource, c => c.GetMember("C.E"), windowsPdb: true); |
Contributor
There was a problem hiding this comment.
Is there a tracking bug for this?
Member
Author
There was a problem hiding this comment.
Not yet, waiting to hear back from the debugger team. I might just be interpreting the API incorrectly.
ryzngard
reviewed
Dec 2, 2021
ryzngard
reviewed
Dec 2, 2021
ryzngard
approved these changes
Dec 2, 2021
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
Signing off in that this looks like a good step forward and most places are clearly marked with TODO.
jasonmalinowski
approved these changes
Dec 2, 2021
allisonchou
added a commit
to allisonchou/roslyn
that referenced
this pull request
Dec 3, 2021
This reverts commit 9af4b1e.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #55834
Follow up to #57978 which implements the actual service and calls the actual debugger.
For now this includes the merge to -vs-deps unfortunately, and there is only one commit to review:
00920ea(#58051)Unfortunately with infrastructure issues, this might not be a clean PR for a little while, so sorry for doing this again, but I would like to get in front of any issues.