Method group conversion caching redo#57882
Closed
pawchen wants to merge 47 commits intodotnet:mainfrom
Closed
Conversation
This was referenced Nov 24, 2021
Contributor
|
@pawchen Ping me once this PR is ready for a look. |
Contributor
Author
|
@AlekseyTs Thanks, it's near. This time I dropped module scoped caching, reducing the complexities by not dealing with the module builders. I run into a few issues here though:
TODOs
I'll close this PR and create another one with cleaner commit history once those issues are clear. |
Contributor
Author
|
OK, because synthesized anonymous delegates are synthesized according to the target method, despite we cannot dig the type parameters out of the delegate symbol, if the target method contains type parameters, we can still detect them there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to help picking up #6642