Skip to content

update error code to fix main break#57739

Merged
333fred merged 1 commit intodotnet:mainfrom
dibarbet:fix_main_errorcode
Nov 12, 2021
Merged

update error code to fix main break#57739
333fred merged 1 commit intodotnet:mainfrom
dibarbet:fix_main_errorcode

Conversation

@dibarbet
Copy link
Copy Markdown
Member

@dibarbet dibarbet commented Nov 12, 2021

two prs merged in at the same time adding the same error code value.
3a74762
c59a4f9

I changed the last one because it doesn't have any documentation that would need to be updated. per Aleksey updating comments for the last one isn't needed.

@dibarbet dibarbet requested a review from a team as a code owner November 12, 2021 20:59
@ghost ghost added the Area-Compilers label Nov 12, 2021
@333fred
Copy link
Copy Markdown
Member

333fred commented Nov 12, 2021

We have a few passing builds/tests, so I'm force merging this to unbreak main.

@333fred 333fred merged commit 144315a into dotnet:main Nov 12, 2021
@ghost ghost added this to the Next milestone Nov 12, 2021
@dibarbet dibarbet deleted the fix_main_errorcode branch November 12, 2021 21:51
333fred added a commit to 333fred/roslyn that referenced this pull request Nov 17, 2021
…rations

* upstream/main: (3387 commits)
  Fix ValueTracking for index parameters (dotnet#57727)
  Avoid accessing current assembly identity while reporting an accessibility diagnostics for an inaccessible internal symbol. (dotnet#57783)
  Include a type for NoneOperations in VB, print the type in tests (dotnet#57664)
  Don't throw exceptions for file changes after a project is unloaded
  Check up front for being called to remove more than once
  Fix C# language name in spec (dotnet#57427)
  Add test
  Fix null ref in navbars
  Ensure that getting the checksum for a project cone is resilient to its project references being missing
  Check constraints on lifted operator types (dotnet#57050)
  Adjust tests for Windows 11 changes (dotnet#57678)
  Add comment
  Load SVsShellDebugger before calling IVsSolution.CreateSolution
  Remove extra EnsureEditableDocuments  calls (dotnet#57725)
  Don't show nullable annotation in completion items of static field/property
  Don't analyze local function bodies as though they are top level code (dotnet#57623)
  update error code to fix main break (dotnet#57739)
  Error when ref is used on a parameter or return type of an UnmanagedCallersOnly method (dotnet#57043)
  Simplify code from review
  Fix featureflag name for .net 6 host in UI
  ...
@allisonchou allisonchou modified the milestones: Next, 17.1.P2 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants