Ensure only one storage service factory gets created per workspace.#57513
Merged
CyrusNajmabadi merged 8 commits intodotnet:mainfrom Nov 2, 2021
Merged
Ensure only one storage service factory gets created per workspace.#57513CyrusNajmabadi merged 8 commits intodotnet:mainfrom
CyrusNajmabadi merged 8 commits intodotnet:mainfrom
Conversation
genlu
reviewed
Nov 1, 2021
src/Workspaces/Core/Portable/Storage/CloudCache/ICloudCacheStorageServiceFactory.cs
Outdated
Show resolved
Hide resolved
genlu
reviewed
Nov 1, 2021
src/Workspaces/Core/Portable/Storage/ISQLiteStorageServiceFactory.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Nov 2, 2021
src/Workspaces/Core/Portable/Storage/SQLite/v2/SQLitePersistentStorageService.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Nov 2, 2021
src/Workspaces/Core/Portable/Storage/CloudCache/ICloudCacheStorageServiceProvider.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Storage/ISQLiteStorageServiceProvider.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Storage/VisualStudioCloudCacheStorageService.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Storage/PersistentStorageExtensions.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Storage/PersistentStorageExtensions.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Storage/SQLite/v2/SQLitePersistentStorageService.cs
Outdated
Show resolved
Hide resolved
599ae0c to
f64ea36
Compare
sharwell
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with the exsiting approach is that we kept getting fresh 'storage service' instances. This meant there was no caching of hte actual 'storage' instance, so we were recreating that instance every time. This was particualr expensive due to how costly it is currently to make a storage instance. That cost though is also heavily mitigate here: #57511