Avoid recomputing expensive persistence location data that does not change.#57511
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Nov 2, 2021
Merged
Conversation
genlu
approved these changes
Nov 1, 2021
CyrusNajmabadi
commented
Nov 1, 2021
| return Path.Combine(appDataFolder, "Microsoft", "VisualStudio", "Roslyn", "Cache"); | ||
| s_cacheDirectory = Path.Combine(appDataFolder, "Microsoft", "VisualStudio", "Roslyn", "Cache"); | ||
|
|
||
| s_moduleFileName = SafeName(Process.GetCurrentProcess().MainModule.FileName); |
Contributor
Author
There was a problem hiding this comment.
in particular, .MainModule turns out to be extremely expensive, and it looks like it is expensive every time it is run. Given that we keep creating fresh storage instances (also addressed here #57513) this turned out to be a huge hotspot.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View with whitespace changes off.