Fix 'simplify conditional expression' with VB value equality#57487
Merged
CyrusNajmabadi merged 12 commits intodotnet:mainfrom Nov 1, 2021
Merged
Fix 'simplify conditional expression' with VB value equality#57487CyrusNajmabadi merged 12 commits intodotnet:mainfrom
CyrusNajmabadi merged 12 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Oct 31, 2021
| Else | ||
| Throw ExceptionUtilities.UnexpectedValue(negatedKind) | ||
| End If | ||
| End Function |
Contributor
Author
There was a problem hiding this comment.
this is the main part of the fix. In VB, when negating an equality expression, we defer to the original syntax to decide what to negate to. so = becomes <> and Is becomes IsNot (and vice versa).
d0e3618 to
dc228f2
Compare
davidwengier
approved these changes
Oct 31, 2021
Member
davidwengier
left a comment
There was a problem hiding this comment.
Should be reviewed as two separate commits.
🤷♂️
...s/SharedUtilitiesAndExtensions/Workspace/Core/Extensions/SyntaxGeneratorExtensions_Negate.cs
Outdated
Show resolved
Hide resolved
ryzngard
approved these changes
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57472
Should be reviewed as two separate commits.