This issue has been moved from a ticket on Developer Community.
[severity:It's more difficult to complete my work] [regression] [worked-in:16.3.1]
A suggested code change recommended comparing two string values using IsNot. This would break the code, because what is required by the existing code is a value comparison, which is nearly always the case when comparing strings.
- Dim name As String = "goober"
- Dim hasName As Boolean = If(name = "", False, True)
The recommended code change was:
- Dim hasName As Boolean = name IsNot ""
Which is plain wrong and breaks the code. However it would compile, so for a novice programmer it appears to work, but the code would fail at runtime. Very Dangerous!!!
Clearly, the recommendation should have been:
- Dim hasName As Boolean = name <> ""
Which correctly uses a value comparison.
Original Comments
Feedback Bot on 10/29/2021, 00:20 AM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.
Original Solutions
(no solutions)
This issue has been moved from a ticket on Developer Community.
[severity:It's more difficult to complete my work] [regression] [worked-in:16.3.1]
A suggested code change recommended comparing two string values using IsNot. This would break the code, because what is required by the existing code is a value comparison, which is nearly always the case when comparing strings.
The recommended code change was:
Which is plain wrong and breaks the code. However it would compile, so for a novice programmer it appears to work, but the code would fail at runtime. Very Dangerous!!!
Clearly, the recommendation should have been:
Which correctly uses a value comparison.
Original Comments
Feedback Bot on 10/29/2021, 00:20 AM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.
Original Solutions
(no solutions)