Disable apphost build of 'csi', 'vbi' for source-build#57306
Closed
dagood wants to merge 1 commit intodotnet:mainfrom
Closed
Disable apphost build of 'csi', 'vbi' for source-build#57306dagood wants to merge 1 commit intodotnet:mainfrom
dagood wants to merge 1 commit intodotnet:mainfrom
Conversation
tmat
approved these changes
Oct 21, 2021
Member
|
Integration failures are expected and will be working again once #57281 merges. |
This was referenced Oct 22, 2021
lbussell
pushed a commit
to lbussell/roslyn
that referenced
this pull request
Jan 7, 2022
Creating an apphost for a netcoreapp3.1 project uses the apphost pack as a prebuilt. Stopping these projects from creating the apphost removes the prebuilt for source-build. See: dotnet#57233 PR: dotnet#57306
lbussell
pushed a commit
to lbussell/roslyn
that referenced
this pull request
Jan 25, 2022
Creating an apphost for a netcoreapp3.1 project uses the apphost pack as a prebuilt. Stopping these projects from creating the apphost removes the prebuilt for source-build. See: dotnet#57233 PR: dotnet#57306
Contributor
|
is this ready to merge (after resolving conflicts)? this often cause patch conflict in installer repo and holds back the update |
Member
|
Yes |
Member
Author
|
/cc @dotnet/source-build-internal |
Member
|
This should be closed in preference of #58727. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
csifor source-build to avoid prebuilt dependency on a 3.1 apphost pack #57233 (more details here)