Add solution sync time telemetry#57269
Merged
tmat merged 2 commits intodotnet:release/dev17.0from Oct 20, 2021
Merged
Conversation
dibarbet
approved these changes
Oct 20, 2021
CyrusNajmabadi
approved these changes
Oct 20, 2021
sharwell
reviewed
Oct 20, 2021
|
|
||
| public async Task SynchronizeSolutionAssetsAsync(Checksum solutionChecksum, CancellationToken cancellationToken) | ||
| { | ||
| var timer = new Stopwatch(); |
Contributor
There was a problem hiding this comment.
💡 Use SharedStopwatch.Start for a zero-alloc equivalent
sharwell
reviewed
Oct 20, 2021
Comment on lines
+93
to
+95
| // report telemetry to help correlate slow solution sync with UI delays | ||
| if (timer.ElapsedMilliseconds > 1000) | ||
| { |
Contributor
There was a problem hiding this comment.
❔ Would it not be better to submit the telemetry 0.01% of the time (Rand(10000)==1), so we get a sampling of performance across the board?
Member
Author
There was a problem hiding this comment.
The goal is to correlate EnC events with this one.
RikkiGibson
added a commit
that referenced
this pull request
Oct 21, 2021
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Oct 22, 2021
* upstream/main: (209 commits) Skip BasicGenerateConstructorDialog.VerifyDeselect fix comment Retry SetForegroundWindow with DTE.MainWindow Skip BasicGenerateConstructorDialog.VerifyReordering removed integration test fix test integration test for analyzer impacted by changes to assembly loading Add MS.CA.CSharp.Workspaces and MS.CA.VB.Workspaces as VSIX analyzer assets Keep around references For correctness builds run on a VS2022 image. feedback Add solution sync time telemetry (dotnet#57269) Also update the dotnet version. Update Building, Debugging, and Testing on Windows.md Update Building, Debugging, and Testing on Unix.md Bump global.json pinned SDK version to NET 6 RC2 remove unused usings DOc comment Update src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.GeneratedFileReplacingCompilationTracker.cs Make non-partial ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report
vs.ide.vbcs.assetservice.perfevent with propertysolutionsynctimewhen solution synchronization to OOP takes more than 1s.Fixes: AB#1423479