Interpolated string handler IOperation support#56276
Merged
333fred merged 10 commits intodotnet:mainfrom Oct 29, 2021
Merged
Conversation
AlekseyTs
reviewed
Sep 9, 2021
48b3749 to
25ef86e
Compare
a941e51 to
0f68158
Compare
Member
Author
|
@AlekseyTs @dotnet/roslyn-compiler this is now ready for review. I'll do CFG support in a follow-up. |
* upstream/main: (209 commits) Skip BasicGenerateConstructorDialog.VerifyDeselect fix comment Retry SetForegroundWindow with DTE.MainWindow Skip BasicGenerateConstructorDialog.VerifyReordering removed integration test fix test integration test for analyzer impacted by changes to assembly loading Add MS.CA.CSharp.Workspaces and MS.CA.VB.Workspaces as VSIX analyzer assets Keep around references For correctness builds run on a VS2022 image. feedback Add solution sync time telemetry (dotnet#57269) Also update the dotnet version. Update Building, Debugging, and Testing on Windows.md Update Building, Debugging, and Testing on Unix.md Bump global.json pinned SDK version to NET 6 RC2 remove unused usings DOc comment Update src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.GeneratedFileReplacingCompilationTracker.cs Make non-partial ...
Member
Author
|
Converting this back to draft while I investigate the bootstrap failure. |
4aeda88 to
5b25f6e
Compare
This was referenced Oct 22, 2021
Member
Author
|
@AlekseyTs @dotnet/roslyn-compiler I've fixed up the CFG issues that were blocking boostrap and this is ready for review. I've specifically kept the CFG implementation minimal: real support will be a followup. |
AlekseyTs
reviewed
Oct 26, 2021
AlekseyTs
reviewed
Oct 26, 2021
AlekseyTs
reviewed
Oct 26, 2021
AlekseyTs
reviewed
Oct 26, 2021
AlekseyTs
reviewed
Oct 26, 2021
src/Compilers/CSharp/Portable/Operations/CSharpOperationFactory.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Oct 26, 2021
src/Compilers/CSharp/Portable/Operations/CSharpOperationFactory.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Oct 26, 2021
src/Compilers/CSharp/Portable/Operations/CSharpOperationFactory.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Oct 26, 2021
AlekseyTs
reviewed
Oct 26, 2021
Contributor
|
Done with review pass (commit 9). |
AlekseyTs
approved these changes
Oct 27, 2021
Contributor
AlekseyTs
left a comment
There was a problem hiding this comment.
LGTM (commit 10), assuming CI is passing.
Member
Author
|
@dotnet/roslyn-compiler for a second review. |
chsienki
approved these changes
Oct 29, 2021
Youssef1313
reviewed
Oct 29, 2021
Comment on lines
+9
to
+10
| public const string AppendFormattedMethod = "AppendFormatted"; | ||
| public const string AppendLiteralMethod = "AppendLiteral"; |
Member
There was a problem hiding this comment.
Could be useful as public API in WellKnownMemberNames?
Member
Author
There was a problem hiding this comment.
If we get a request for it, we could potentially add it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for interpolated strings in IOperation. Implements part 1 of #54718. CFG will come in a follow-up to keep the review size manageable.