Fix shadow copy loader in framework#56027
Merged
RikkiGibson merged 3 commits intodotnet:mainfrom Aug 31, 2021
Merged
Conversation
chsienki
reviewed
Aug 31, 2021
| return Assembly.LoadFrom(pathToLoad); | ||
| } | ||
|
|
||
| protected virtual Assembly LoadImpl(string fullPath) => Assembly.LoadFrom(fullPath); |
Member
There was a problem hiding this comment.
Is this used from any other base code?
Member
Author
There was a problem hiding this comment.
I think I deleted all the overrides and usages of this, but accidentally left the original declaration around as a vestige.
chsienki
approved these changes
Aug 31, 2021
jaredpar
approved these changes
Aug 31, 2021
jasonmalinowski
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1389790
Added a test which actually performs a deletion and manually verified the scenario in the linked issue.