Skip to content

EnC - Parameterless struct constructors#55718

Merged
davidwengier merged 6 commits intodotnet:mainfrom
davidwengier:EnCStructConstructor
Aug 20, 2021
Merged

EnC - Parameterless struct constructors#55718
davidwengier merged 6 commits intodotnet:mainfrom
davidwengier:EnCStructConstructor

Conversation

@davidwengier
Copy link
Copy Markdown
Member

Fixes #55547

Feels too easy, probably missing something ¯\_(ツ)_/¯

@davidwengier davidwengier requested a review from tmat August 19, 2021 05:52
@davidwengier davidwengier requested review from a team as code owners August 19, 2021 05:52
@ghost ghost added the Area-Compilers label Aug 19, 2021
Copy link
Copy Markdown
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test only change? LGTM :shipit:

}

[Theory]
[InlineData("class ")]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space

Copy link
Copy Markdown
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tmat
Copy link
Copy Markdown
Member

tmat commented Aug 19, 2021

Do we have test for parameterless ctor in records and record structs? Might be good to add one.

BTW, noticed #52563 is closed by still references in the source code.

@davidwengier
Copy link
Copy Markdown
Member Author

davidwengier commented Aug 19, 2021

BTW, noticed #52563 is closed by still references in the source code.

Whoops, thanks. Logged #55732 to follow up

@davidwengier davidwengier enabled auto-merge (squash) August 19, 2021 23:46
@davidwengier davidwengier merged commit 16efcb2 into dotnet:main Aug 20, 2021
@ghost ghost added this to the Next milestone Aug 20, 2021
@davidwengier davidwengier deleted the EnCStructConstructor branch August 20, 2021 06:17
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EnC analyzer needs to be updated for parameterless struct ctors

4 participants