Merged
Conversation
…729.14 (#55336) [main] Update dependencies from dotnet/roslyn
Update PublishData.json after P3 M2 snap
Revert "Merge pull request #54323 from dotnet/darc-release/dev16.11-8…
…release/dev16.11-to-release/dev17.0
Enable rollforward
…ase/dev17.0 Merge release/dev16.11 to release/dev17.0
The logic for how to communicate with the compiler server was spread out amongst a number of types in the code and it was causing a few problems: 1. Made the server protocol hard to understand because you had to dig through 3-4 different types to understand the interactions. 2. Made testing real scenarios difficult because the logic was in the wrong places (why should the csc.exe know anything about how connections are managed?) 3. Lead to too many knobs being put into the APIs that created scenarios that needed to be tested that never actually occurred in production code. This change was mostly spurred by (2) above. In a recent bug fix I ended up spending far too much time trying to write a very simple test. It motivated me to finally fix this up. The bulk of the change is in `BuildServerConnection.cs`. That is now the central point for all logic around how the server is started, build requests are processed and how the server is shut down. All logic for that set of interaction should now be centralized here.
Merge release/dev17.0 to main
… 20210730.1 (#55317) [main] Update dependencies from dotnet/source-build
…729.2 (#55271) [main] Update dependencies from dotnet/arcade
dddd4e3 to
a80a586
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from main into main-vs-deps.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout merges/main-to-main-vs-deps git reset --hard upstream/main-vs-deps git merge upstream/main # Fix merge conflicts git commit git push upstream merges/main-to-main-vs-deps --force