Cleaning up compiler server interface#52805
Merged
jaredpar merged 13 commits intodotnet:mainfrom Aug 2, 2021
Merged
Conversation
Member
Author
|
@dotnet/roslyn-compiler PTAL |
chsienki
reviewed
Jul 20, 2021
chsienki
approved these changes
Jul 20, 2021
RikkiGibson
reviewed
Jul 21, 2021
Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
Member
Author
|
@RikkiGibson feedback addressed 😄 |
RikkiGibson
reviewed
Aug 2, 2021
| try | ||
| { | ||
| var process = Process.GetProcessById(shutdownBuildResponse.ServerProcessId); | ||
| #if NET50_OR_GREATER |
Member
There was a problem hiding this comment.
I wasn't sure when we actually target net5.0 currently.
RikkiGibson
approved these changes
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for how to communicate with the compiler server was spread out amongst a number of types in the code and it was causing a few problems:
This change was mostly spurred by (2) above. In a recent bug fix I ended up spending far too much time trying to write a very simple test. It motivated me to finally fix this up.
The bulk of the change is in
BuildServerConnection.cs. That is now the central point for all logic around how the server is started, build requests are processed and how the server is shut down. All logic for that set of interaction should now be centralized here.