Make dynamic path map case insensitive to match source files#55363
Merged
davidwengier merged 1 commit intodotnet:mainfrom Aug 5, 2021
Merged
Make dynamic path map case insensitive to match source files#55363davidwengier merged 1 commit intodotnet:mainfrom
davidwengier merged 1 commit intodotnet:mainfrom
Conversation
|
NTaylorMullen
approved these changes
Aug 3, 2021
| /// We use the same string comparer as in the <see cref="BatchingDocumentCollection"/> used by _sourceFiles, below, as these | ||
| /// files are added to that collection too. | ||
| /// </remarks> | ||
| private readonly Dictionary<string, string?> _dynamicFilePathMaps = new(StringComparer.OrdinalIgnoreCase); |
Member
Author
There was a problem hiding this comment.
Yes, but even if its not, its probably better that source files and dynamic files make the same mistakes 😛
ryzngard
approved these changes
Aug 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55362
Fixes https://github.com/dotnet/aspnetcore/issues/34963
Simple change, really painful to track down.
/cc @NTaylorMullen