Ensure we don't try and build an empty table when modifying entries #54639
Merged
chsienki merged 1 commit intodotnet:mainfrom Jul 6, 2021
Merged
Ensure we don't try and build an empty table when modifying entries #54639chsienki merged 1 commit intodotnet:mainfrom
chsienki merged 1 commit intodotnet:mainfrom
Conversation
Member
Author
|
@dotnet/roslyn-compiler for review please |
jaredpar
approved these changes
Jul 6, 2021
cston
approved these changes
Jul 6, 2021
allisonchou
pushed a commit
to allisonchou/roslyn
that referenced
this pull request
Jul 6, 2021
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 8, 2021
* upstream/main: (559 commits) Remove a few unused error codes (dotnet#54663) Use specific error message for wrong arity in async builder (dotnet#54632) Update azure-pipelines-richnav.yml (dotnet#54662) Capture file content on open instead of save (dotnet#54643) Add docs Further FAR simplifications Handle enhanced #line directive in DirectiveTriviaSyntax.DirectiveNameToken (dotnet#54636) move server name outside of loop Fix functionid Reduce telemetry output from find document in workspace Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639) Feedback Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639) No need to specialized logic for determining set of projects to search Defer group computation till reporting time Handle FAR for global suppressions in a consistent fashion Update status for enhanced `#line` directive (dotnet#54581) Split IOperationTests into one part per type [LSP] Revert semantic tokens change in main (dotnet#54570) Add exceptionutilities unreachable to catch blocks that should not be hit ...
allisonchou
pushed a commit
that referenced
this pull request
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modification algorithm wasn't taking into account the case when there was an entry that contained no values with a corresponding modification that also had no values.
Fixes #54470