Merged
Conversation
Member
Author
|
Merging without review so I can flow through and hopefully mitigate an official build issue. |
RikkiGibson
added a commit
to RikkiGibson/roslyn
that referenced
this pull request
Jun 27, 2021
RikkiGibson
added a commit
that referenced
this pull request
Jun 28, 2021
Backport "Insertion depends on DARC publishing (#54420)"
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jun 28, 2021
…rations * upstream/main: (875 commits) Merge pull request dotnet#54453 from davidwengier/FixBuild Move string to resources Fix window missing title. Move string to resources Fix test Update dependencies from https://github.com/dotnet/roslyn build 20210627.4 (dotnet#54441) Set AutoComplete based on CreateDraftPR Docs remove semantic version check Move to a simpler event source system for nav bars. Insertion depends on DARC publishing (dotnet#54420) Simplify delay Simplify delay Fix add parameter for records Insertion depends on DARC publishing (dotnet#54420) Fix move type for top level statements [main] Update dependencies from dotnet/source-build (dotnet#54384) Update DefaultDiagnosticModeServiceFactory.cs Create default option for lsp pull diagnostics to allow it to be switched on via feature flag Switch to correct workspace api to get active context Clean code ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example run (internal only): https://dev.azure.com/dnceng/internal/_build/results?buildId=1207982&view=results
(Unfortunately, I think symbol publishing from dev branches may be broken, so the example doesn't end up being extremely meaningful.)
The insertion tool is too fast currently, so we have to slow it down to keep other infrastructure from having issues 😅
If we insert to VS as soon as the
buildstage is complete, most things just work, but the Insertion Symbol Check usually fails because the symbols aren't actually available yet on the symbol server. This change makes it so we delay inserting until all other publishing and validation is done, This slows down the insertion by maybe 30 minutes, but makes it so the developer doesn't need to manually re-run the Insertion Symbol Check.If we were to figure out a way to kick off the insertion after just the
buildstage is complete, then delay running the Insertion Symbol Check until the symbols are ready, we could save a significant chunk of time in the loop from merging on GitHub to inserting into VS. Also, in the past, there have been issues where symbols were slow to become available, and even the mitigation in this PR wouldn't have been sufficient, so it could provide additional resiliency in the future. dotnet/roslyn-tools#1017@JoeRobich @dotnet/roslyn-infrastructure for review