Skip to content

Remove SyntaxKind.DataKeyword#53614

Merged
jcouv merged 5 commits intodotnet:mainfrom
Youssef1313:retire-syntaxkind-datakeyword
May 23, 2021
Merged

Remove SyntaxKind.DataKeyword#53614
jcouv merged 5 commits intodotnet:mainfrom
Youssef1313:retire-syntaxkind-datakeyword

Conversation

@Youssef1313
Copy link
Member

Fixes #53589

@Youssef1313 Youssef1313 requested review from a team as code owners May 22, 2021 06:34
@ghost ghost added the Area-Compilers label May 22, 2021
@Youssef1313
Copy link
Member Author

.tools\msbuild\16.8.0-preview2.1\tools\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(10,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) Failed to download package 'VsWebsite.Interop.8.0.50727' from 'https://pkgs.dev.azure.com/azure-public/3ccf6661-f8ce-4e8a-bb2e-eff943ddd3c7/_packaging/2a239fd0-3e21-40b0-b9d6-bc122fec7eb2/nuget/v3/flat2/vswebsite.interop/8.0.50727/vswebsite.interop.8.0.50727.nupkg'.
Response status code does not indicate success: 503 (Operations per second is over the account limit.).

@Youssef1313 Youssef1313 reopened this May 22, 2021
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 5)

@jcouv jcouv merged commit a716b18 into dotnet:main May 23, 2021
@ghost ghost added this to the Next milestone May 23, 2021
@jcouv
Copy link
Member

jcouv commented May 23, 2021

Merged/squashed. Thanks @Youssef1313 !

@jcouv jcouv added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 23, 2021
@Youssef1313 Youssef1313 deleted the retire-syntaxkind-datakeyword branch May 23, 2021 17:46
@jcouv jcouv added the Feature - Records Records label May 23, 2021
/// <summary>Represents <see langword="data"/>.</summary>
DataKeyword = 8441,

// 8441 open for future use.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// 8441 open for future use.

@333fred, @jcouv

I believe the decision of compat council was to reserve the number. I.e. prevent its reuse now or in the future. It doesn't look like this comment is in line with that.

@Youssef1313 Youssef1313 mentioned this pull request May 24, 2021
333fred added a commit that referenced this pull request May 24, 2021
…ures/interpolated-string

* upstream/main: (92 commits)
  Keep casts when necessary to prefer a constant pattern over a type pattern
  Remove SyntaxKind.DataKeyword (#53614)
  Display 'readonly' for record structs (#53634)
  Update Building, Debugging, and Testing on Windows.md (#53543)
  Update dependencies from https://github.com/dotnet/arcade build 20210521.3 (#53617)
  Introduce resx for BuildValidator and MS.CA.Rebuild to allow localization (#53447)
  Report obsoletion diagnostics for slice and indexer (#53463)
  Update BasicGenerateConstructorDialog.cs
  Add searchbox in generate overrides dialog
  Allow `with` on anonymous types (#53248)
  Report diagnostic on correct node (#53538)
  Fix NotNullIfNotNull delegate conversion (#53409)
  Verify quick info session in InvokeQuickInfo
  Remove unnecessary retry
  Ensure no navbar IO on the UI thread
  Enable nullable reference types
  Fix timeout behavior in GetQuickInfo
  Add a semantic model based GetQuickInfoAsync entry point into QuickInfoServiceWithProviders
  Move semantic model based quick info API up to CommonQuickInfoProvider type
  Fix dnceng build by forcing the use of xcopy msbuild
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Feature - Records Records

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obsolete/remove SyntaxKind.DataKeyword API

5 participants