Skip to content

Fix EnC capabilties check for runtimes that aren't returning capabilities yet#53000

Merged
davidwengier merged 1 commit intodotnet:release/dev16.10from
davidwengier:EnCFixCapabilities
Apr 29, 2021
Merged

Fix EnC capabilties check for runtimes that aren't returning capabilities yet#53000
davidwengier merged 1 commit intodotnet:release/dev16.10from
davidwengier:EnCFixCapabilities

Conversation

@davidwengier
Copy link
Member

@davidwengier davidwengier commented Apr 28, 2021

... which is all of them 🤦‍♂️

FYI @jinujoseph this needs to go through M2.

/cc @tmat @dibarbet

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1320766

@davidwengier davidwengier requested a review from a team as a code owner April 28, 2021 22:30
@ghost ghost added the Area-Interactive label Apr 28, 2021
@jinujoseph jinujoseph added this to the 16.10.P3 milestone Apr 28, 2021
@davidwengier davidwengier enabled auto-merge (squash) April 28, 2021 22:48
@davidwengier
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@davidwengier
Copy link
Member Author

I'm hoping the integration test failures are known, and not related to my changes :(

@davidwengier davidwengier merged commit f015548 into dotnet:release/dev16.10 Apr 29, 2021
@davidwengier
Copy link
Member Author

err.. github merged this with a failing lsp integration test.. hopefully thats by design ¯\_(ツ)_/¯

@davidwengier davidwengier deleted the EnCFixCapabilities branch April 29, 2021 06:23
333fred added a commit to 333fred/roslyn that referenced this pull request May 5, 2021
…into bind-strings

* upstream/features/interpolated-string: (912 commits)
  Update version for 16.11
  Avoid false assert in AssertMemberExposure due to a race. (dotnet#53044)
  Fix caret placement for argument completion snippets
  Explicitly define no PR triggers as they are on 'by default'
  Remove eng/docker/mono.sh script (dotnet#51833)
  Run LSP integration on CI builds only until they're stable
  Implement the right interface
  Disable CompileTimeSolutionProvider
  Avoid negative logic when checking whether a eol is present
  Update src/Analyzers/CSharp/CodeFixes/UseSimpleUsingStatement/UseSimpleUsingStatementCodeFixProvider.cs
  Apply suggestions
  Adapt codestyle
  Prepend first statement of using block with a newline, if opening bracket is on same line as using statement
  Fix EnC capabilties check for runtimes that aren't returning capabilities yet (dotnet#53000)
  Add ConfigureAwait calls to cocoa code.
  Remove CustomTags from CodeAction constructors
  Make CodeAction.CustomTags internal
  Update "contributing" doc with pointers on IOperation test hook (dotnet#52978)
  Cocoa part
  Switch to a simpler cancellation ownership model for the FAR window. (Cocoa still to come)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants