Merged
Conversation
…etween ) and throw
Co-authored-by: Jason Malinowski <jason.malinowski@microsoft.com>
…CheckTests.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
* Fix race conditions in attribute asserts There are asserts in our `CustomAttributeBag` to verify we maintain the invariant that early decoding occurs before the full decoding. The asserts though done in the getters and take the following form: ```cs bool earlyComplete = IsPartComplete(CustomAttributeBagCompletionPart.EarlyDecodedWellKnownAttributeData); // If late attributes are complete, early attributes must also be complete Debug.Assert(!IsPartComplete(CustomAttributeBagCompletionPart.DecodedWellKnownAttributeData) || earlyComplete); return earlyComplete; ``` This pattern is subject to race conditions. Consider the case where the `bool earlyComplete` statement runs to completion and returns `false`. Then another thread swaps in and completes both early and full decoding. At that point the original thread resumes and the `Debug.Assert` will fail yet no invariant has been violated. Moved the `Debug.Assert` into the setters where we can reliably test the state invariants. closes #52372 related to #52368 * Fix * Add back an assert
"Add null check" inserts single line statements if preferred
Add publish data for d17p1 branch
Use CancellationSeries in ExternalErrorDiagnosticUpdateSource
Update CONTRIBUTING.md
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from main into main-vs-deps.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout merges/main-to-main-vs-deps git reset --hard upstream/main-vs-deps git merge upstream/main # Fix merge conflicts git commit git push upstream merges/main-to-main-vs-deps --force