Skip to content

Update CONTRIBUTING.md#52474

Merged
jmarolf merged 2 commits intomainfrom
fix-contributing
Apr 9, 2021
Merged

Update CONTRIBUTING.md#52474
jmarolf merged 2 commits intomainfrom
fix-contributing

Conversation

@jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Apr 7, 2021

No description provided.

@ghost ghost added the Area-Infrastructure label Apr 7, 2021
JoeRobich
JoeRobich approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow =)

@jmarolf jmarolf enabled auto-merge April 7, 2021 21:11
jasonmalinowski
jasonmalinowski reviewed Apr 7, 2021
View reviewed changes
CONTRIBUTING.md Outdated
## Submitting Pull Requests

- **DO** ensure submissions pass all Jenkins legs and are merge conflict free.
- **DO** ensure submissions pass all Azure Devops legs and are merge conflict free.
Copy link
Member

@jasonmalinowski jasonmalinowski Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this make it clear that if you're unsure, just submit a draft PR? This otherwise mandates a standard that our own team doesn't meet.

Copy link
Member

@jasonmalinowski jasonmalinowski Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(don't let this question derail merging this fix, because this his hilariously bad.)

Copy link
Contributor Author

@jmarolf jmarolf Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that someone should look at our contributing docs... This is a general pain point I feel on the team today: should I even bother running Test.cmd? Seems like most folks just submit PRs because Test.cmd has drifted so far from reality.

jasonmalinowski
jasonmalinowski reviewed Apr 7, 2021
View reviewed changes
@jmarolf @jasonmalinowski
Update CONTRIBUTING.md
721889e 
Co-authored-by: Jason Malinowski <jason.malinowski@microsoft.com>
@Youssef1313
Copy link
Member

Youssef1313 commented Apr 8, 2021

This is part of #50579.

@jmarolf
Copy link
Contributor Author

jmarolf commented Apr 8, 2021 •
edited
Loading

@jaredpar or @RikkiGibson I keep getting this in the correctness leg

Command failed to execute with exit code 1: D:\workspace\_work\1\s\artifacts/bin/BuildValidator/Release/net472/BuildValidator.exe --verbose --assembliesPath "D:\workspace\_work\1\s\artifacts/obj/" --exclude net472\Microsoft.CodeAnalysis.EditorFeatures.Wpf.dll --exclude net472\Microsoft.VisualStudio.LanguageServices.CSharp.dll --exclude net472\Microsoft.VisualStudio.LanguageServices.dll --exclude net472\Microsoft.VisualStudio.LanguageServices.Implementation.dll --exclude net472\Microsoft.VisualStudio.LanguageServices.VisualBasic.dll --exclude net472\Roslyn.Hosting.Diagnostics.dll --exclude net472\Roslyn.VisualStudio.DiagnosticsWindow.dll --exclude netcoreapp3.1\Microsoft.CodeAnalysis.Collections.Package.dll --exclude netstandard2.0\Microsoft.CodeAnalysis.Collections.Package.dll --exclude net45\Microsoft.CodeAnalysis.Debugging.Package.dll --exclude netstandard1.3\Microsoft.CodeAnalysis.Debugging.Package.dll --exclude net45\Microsoft.CodeAnalysis.PooledObjects.Package.dll --exclude netstandard1.3\Microsoft.CodeAnalysis.PooledObjects.Package.dll --exclude netcoreapp3.1\Microsoft.CodeAnalysis.Workspaces.UnitTests.dll --exclude net472\Zip\tools\vsixexpinstaller\System.ValueTuple.dll --exclude net472\Zip\tools\vsixexpinstaller\VSIXExpInstaller.exe --debugPath "D:\workspace\_work\1\s\artifacts/BuildValidator" --sourcePath "D:\workspace\_work\1\s" --referencesPath "D:\workspace\_work\1\s\artifacts/bin" --referencesPath "D:\workspace\_work\1\s\.dotnet/packs"
System.Management.Automation.RuntimeException: Command failed to execute with exit code 1: D:\workspace\_work\1\s\artifacts/bin/BuildValidator/Release/net472/BuildValidator.exe --verbose --assembliesPath "D:\workspace\_work\1\s\artifacts/obj/" --exclude net472\Microsoft.CodeAnalysis.EditorFeatures.Wpf.dll --exclude net472\Microsoft.VisualStudio.LanguageServices.CSharp.dll --exclude net472\Microsoft.VisualStudio.LanguageServices.dll --exclude net472\Microsoft.VisualStudio.LanguageServices.Implementation.dll --exclude net472\Microsoft.VisualStudio.LanguageServices.VisualBasic.dll --exclude net472\Roslyn.Hosting.Diagnostics.dll --exclude net472\Roslyn.VisualStudio.DiagnosticsWindow.dll --exclude netcoreapp3.1\Microsoft.CodeAnalysis.Collections.Package.dll --exclude netstandard2.0\Microsoft.CodeAnalysis.Collections.Package.dll --exclude net45\Microsoft.CodeAnalysis.Debugging.Package.dll --exclude netstandard1.3\Microsoft.CodeAnalysis.Debugging.Package.dll --exclude net45\Microsoft.CodeAnalysis.PooledObjects.Package.dll --exclude netstandard1.3\Microsoft.CodeAnalysis.PooledObjects.Package.dll --exclude netcoreapp3.1\Microsoft.CodeAnalysis.Workspaces.UnitTests.dll --exclude net472\Zip\tools\vsixexpinstaller\System.ValueTuple.dll --exclude net472\Zip\tools\vsixexpinstaller\VSIXExpInstaller.exe --debugPath "D:\workspace\_work\1\s\artifacts/BuildValidator" --sourcePath "D:\workspace\_work\1\s" --referencesPath "D:\workspace\_work\1\s\artifacts/bin" --referencesPath "D:\workspace\_work\1\s\.dotnet/packs"
##[error]PowerShell exited with code '1'.

Can't seem to find an existing bug on it. (an no logs are written out anywhere) has this ever been seen before? I can't imagine this markdown update is actually causing a build correctness problem

@RikkiGibson
Copy link
Member

RikkiGibson commented Apr 8, 2021

@jaredpar has observed flakiness when rebuilding that and has disabled that rebuilding that project in another PR. Sorry for the inconvenience.

@jmarolf
Copy link
Contributor Author

jmarolf commented Apr 9, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 9, 2021

Azure Pipelines successfully started running 3 pipeline(s).

@jmarolf jmarolf merged commit 5509233 into main Apr 9, 2021
@ghost ghost added this to the Next milestone Apr 9, 2021
@RikkiGibson RikkiGibson deleted the fix-contributing branch April 9, 2021 21:31
@dibarbet dibarbet modified the milestones: Next, 16.10.P3 Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski left review comments

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees

No one assigned

Labels

Area-Infrastructure

Projects

None yet

Milestone

16.10.P3

Development

Successfully merging this pull request may close these issues.

6 participants

@jmarolf @Youssef1313 @RikkiGibson @jasonmalinowski @JoeRobich @dibarbet