Conversation
There was a problem hiding this comment.
the name before was correct. it is exposed outside the type, so should be pascal cased. _ is for privates.
There was a problem hiding this comment.
this scares me. skipping for now.
src/Workspaces/Core/MSBuild/MSBuild/MSBuildProjectLoader.Worker_ResolveReferences.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
i triply hate ths now. having another type access an _ member of another varaible looks like it's somehow accessing a privat.e
There was a problem hiding this comment.
honestly i dont' get why this is a switch, and not just return X || Y || Z;
|
So i ended up skpping this. lots of mechanical changes i approve of, and would accept a PR on. I don't like intermixing it with things taht are sublte and could change semantics. c an you break apart? |
|
Marked as draft since it builds on #52389 |
4c6affb to
db1d1c8
Compare
db1d1c8 to
b50dd24
Compare
|
splitting into different PRs |
No description provided.