Skip to content

enable nullable in MSBuildWorkspace#52389

Merged
jmarolf merged 7 commits intodotnet:mainfrom
jmarolf:infra/msbuildworkspace-nullable-enable
Apr 8, 2021
Merged

enable nullable in MSBuildWorkspace#52389
jmarolf merged 7 commits intodotnet:mainfrom
jmarolf:infra/msbuildworkspace-nullable-enable

Conversation

@jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Apr 3, 2021

No description provided.

@jmarolf jmarolf requested review from a team and sharwell April 3, 2021 03:18
@ghost ghost added the Area-IDE label Apr 3, 2021
Copy link
Contributor

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with 28/42 files so far

Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

#nullable disable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jmarolf jmarolf requested review from a team, CyrusNajmabadi, JoeRobich and sharwell April 8, 2021 02:17
…r_ResolveReferences.cs

Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
@jmarolf jmarolf enabled auto-merge April 8, 2021 04:28
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jmarolf jmarolf merged commit 75ad686 into dotnet:main Apr 8, 2021
@ghost ghost added this to the Next milestone Apr 8, 2021
@dibarbet dibarbet modified the milestones: Next, 16.10.P3 Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants