Skip to content

XamlProjectService fixes#49711

Merged
mgoertz-msft merged 4 commits intodotnet:masterfrom
mgoertz-msft:dev/mgoertz/doctracking
Dec 10, 2020
Merged

XamlProjectService fixes#49711
mgoertz-msft merged 4 commits intodotnet:masterfrom
mgoertz-msft:dev/mgoertz/doctracking

Conversation

@mgoertz-msft
Copy link
Contributor

  • Fixes issue Move UI thread dependencies out of the XamlProjectService MEF constructor #48651: Initialize VS services on demand on the UI thread
  • Fixes DevDiv Bug 1248612: The MainWindow.xaml designer file pops up an "ArgumentException"exception, when clicking "Compare Current and Incoming": Avoid tracking "documents" with empty paths (e.g. while diffing).
  • RDT info does not always contain the hierarchy when closing. Switch to a more reliable cookie-based tracking system instead.

Avoid tracking "documents" with empty paths (e.g. while diffing).
RDT info does not always contain the hierarchy when closing. Switch to a more reliable cookie-based tracking system instead.
@mgoertz-msft
Copy link
Contributor Author

@dibarbet Could you please take a look when you get a moment? This fixes issue #48651 that you were concerned about in a previous change to this file as well as a couple other problems for 16.9 (see description above). Thanks.

@mgoertz-msft
Copy link
Contributor Author

@jasonmalinowski Looks like the test failures are all caused by #49399. Any other concerns before signing off?

@mgoertz-msft
Copy link
Contributor Author

@jasonmalinowski, @dibarbet Ping. :)

@mgoertz-msft
Copy link
Contributor Author

Anyone else who can sign off here? @CyrusNajmabadi?

Copy link
Contributor

@LinglingTong LinglingTong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mgoertz-msft mgoertz-msft merged commit 908a7c9 into dotnet:master Dec 10, 2020
@ghost ghost added this to the Next milestone Dec 10, 2020
@mgoertz-msft mgoertz-msft deleted the dev/mgoertz/doctracking branch December 10, 2020 03:06
333fred added a commit to 333fred/roslyn that referenced this pull request Dec 15, 2020
* upstream/master: (241 commits)
  Allow pattern matching `null` against pointer types when the pointer types contain nested type parameters (dotnet#49915)
  Remove document extension method and convert usages to use the text buffer extension method.
  VB: Strengthen implementation of `PropertySymbol.IsWritable` against NullReferenceException (dotnet#49962)
  Add switch to skip nullable analysis (dotnet#49876)
  Update dependencies from https://github.com/dotnet/roslyn build 20201211.16 (dotnet#49958)
  Treat record positional parameters as properties (dotnet#48329)
  [master] Update dependencies from dotnet/roslyn (dotnet#49395)
  VB: Ensure array access indexes undergo conversion to integer even when there is a mismatch with array rank. (dotnet#49907)
  Disable OOP when running as cloud environment client VS instance
  Rename workspace context method (and unify impls) to better represent the condition being checked
  Report non-Const locals used in an expression that must have a constant value. (dotnet#49912)
  Add support for more ServiceAudience values (dotnet#49914)
  Handle ref-containing structs returned by value from function-pointers (dotnet#49883)
  Fix error on out param of extern local function (dotnet#49860)
  Fix constructor exit warnings for generic NotNull (dotnet#49841)
  Loc updates
  Prefer more specific path map key (dotnet#49670)
  Rename `_availablelocalFunctionOrdinal` to `_availableLocalFunctionOrdinal` (dotnet#49901)
  Fix namespace so that external access wrapper type can be accessed from UT.
  XamlProjectService fixes (dotnet#49711)
  ...
@dibarbet dibarbet modified the milestones: Next, 16.9.P3 Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move UI thread dependencies out of the XamlProjectService MEF constructor

4 participants