Skip to content

Fix APIs for retrieving solution snapshot from Razor, UT#49591

Merged
tmat merged 7 commits intodotnet:masterfrom
tmat:RazorISB
Dec 3, 2020
Merged

Fix APIs for retrieving solution snapshot from Razor, UT#49591
tmat merged 7 commits intodotnet:masterfrom
tmat:RazorISB

Conversation

@tmat
Copy link
Member

@tmat tmat commented Nov 24, 2020

Contributes to #49591

Remove RemoteWorkspaceSolutionProviderService ISB service - it's actually not needed.

Add serializable wrapper structs for PinnedSolutionInfo.

Allow using JSON serialization for ISB services - this is currently required by Razor. They use JSON serializer for multiple purposes and can't replace it completely by message pack yet.

@tmat tmat marked this pull request as ready for review November 24, 2020 17:06
@tmat tmat requested review from a team as code owners November 24, 2020 17:06
@tmat tmat merged commit 7b490bb into dotnet:master Dec 3, 2020
@ghost ghost added this to the Next milestone Dec 3, 2020
@tmat tmat deleted the RazorISB branch December 3, 2020 23:29
@tmat tmat modified the milestones: Next, 16.9.P2 Dec 3, 2020
333fred added a commit to 333fred/roslyn that referenced this pull request Dec 5, 2020
* upstream/master: (143 commits)
  Use Unicode for OutputEncoding (dotnet#49721)
  Fix tests
  Remove unnecessary parens when converting switch statement ot expression.
  Fix flaky test
  Simplify implementation of IsOrInGenericType helper and reduce code duplication. (dotnet#49763)
  Increase CoreCLR dump information
  NRT
  Be resilient to a null-document in the code-folding service.
  Change cache implementation from dictionary to list
  Fix APIs for retrieving solution snapshot from Razor, UT (dotnet#49591)
  Handles optional parameters
  Feature/disambiguate using keyword (dotnet#48898)
  Check all overloads when inferring first argument in an invocation with nothing typed
  Remove optional parameter
  lint
  Clean up option handling
  Remove double blank line
  Add + update tests
  Ensure completion and completion resolve handler always pass the same options
  Change name of telemetry
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants