Skip to content

Add CallerMemberNameAttributeWithImplicitObjectCreation test#49556

Merged
RikkiGibson merged 2 commits intodotnet:masterfrom
Youssef1313:patch-8
Nov 23, 2020
Merged

Add CallerMemberNameAttributeWithImplicitObjectCreation test#49556
RikkiGibson merged 2 commits intodotnet:masterfrom
Youssef1313:patch-8

Conversation

@Youssef1313
Copy link
Member

Closes #49547

@Youssef1313
Copy link
Member Author

The failing test here is unrelated. Could someone re-run the failed job?

@RikkiGibson RikkiGibson added Community The pull request was submitted by a contributor who is not a Microsoft employee. Test Test failures in roslyn-CI labels Nov 22, 2020
@RikkiGibson
Copy link
Member

I got curious and tried cherry-picking this change into different revisions. I found that #49186 fixes this scenario (completely unintentionally). Thanks for adding the test @Youssef1313.

@RikkiGibson RikkiGibson merged commit 5987e53 into dotnet:master Nov 23, 2020
@ghost ghost added this to the Next milestone Nov 23, 2020
@Youssef1313 Youssef1313 deleted the patch-8 branch November 23, 2020 08:55
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
333fred added a commit to 333fred/roslyn that referenced this pull request Nov 30, 2020
* upstream/master: (265 commits)
  Use extra generic type parameters and apply C#-specific knowledge to all langs instead of using inheritance
  Cover all changed code paths
  Stop removing parens that are required by C#
  Fix unnecessary spans
  Failing test for preserving parens around conditional expression
  AddSynthesizedRecordMembersIfNecessary - avoid touching members that are known to have no effect on the outcome of the function. (dotnet#49610)
  Resolve follow-up comments in PR "Create default arguments during binding" (dotnet#49588)
  Remove restore and checkout from test jobs (dotnet#49452)
  3.8.* -> 3.9.*
  Update PublishData.json
  Update Versions.props
  Remove Microsoft.CodeAnalysis.VisualBasic.dll from the VSPE.OptProfTests.DDRIT_RPS_ManagedLangs_Typing runs
  Fix the ability to expand the list of analyzers in a reference
  Fix comment
  Address feedback to ensure `/warnaserror-:ID` prevents config options from bumping a warning to an error.
  parallel restore on mac/linux (dotnet#49523)
  VSMac: Make QuickFix preview resizable and add title (dotnet#49394)
  Add CallerMemberNameAttributeWithImplicitObjectCreation test (dotnet#49556)
  Update dependencies from https://github.com/dotnet/arcade build 20201120.10 (dotnet#49541)
  Clarify comment
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Test Test failures in roslyn-CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CallerMemberName should work on target typed new()

4 participants