Overwrite xunit's app domain handling to not call AppDomain.Unload#49355
Merged
sharwell merged 4 commits intodotnet:masterfrom Nov 13, 2020
Merged
Overwrite xunit's app domain handling to not call AppDomain.Unload#49355sharwell merged 4 commits intodotnet:masterfrom
sharwell merged 4 commits intodotnet:masterfrom
Conversation
sharwell
commented
Nov 13, 2020
CyrusNajmabadi
approved these changes
Nov 13, 2020
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
fine with this as long as we have a comment linking to wahtever issue/pr we raised on the xunit side that we couldn't effectivel move forward with.
Member
|
This is beautiful evil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping this avoids the need to maintain our own copy of the xunit runners, by patching the implementation at runtime to apply xunit/xunit#2192.
Fixes #15497
Fixes #40369
Fixes #48989
Fixes #49024
Fixes #49035
Fixes #49275