Add environment variable to override AppDomain.Unload#2192
Add environment variable to override AppDomain.Unload#2192
Conversation
|
@bradwilson I'm having trouble building this for test. If CI could publish a build to the package feed we can update our CI and verify over the next week that the timeouts are gone. |
|
There's no CI for v2 any more, because there are no plans to release any more v2 releases. The AppVeyor account was closed down some time ago. |
|
@bradwilson I verified locally that this change fixes at least one of the common delays. This is certainly a multiple-times-per-day pain point for the Roslyn team. |
|
I could try to help figure out your build issues so that you could publish your own internal package. |
|
📝 I am able to build this from dde9f82. If we were to publish a fork of the runner, it would probably just eliminate the call to |
|
@bradwilson this is no longer needed. We implemented a change to patch the x86/x64 assembly in memory at runtime and it met our needs. |
This pull request provides a mitigation path for dotnet/roslyn#49024.
I considered three approaches:
appDomainUnload, with default valuetrue. This is the cleanest option for a user, but is difficult to implement throughout the internals without breaking API changes.AppDomainSupportto have an enum flag for this. This seemed like a reasonable possibility, but likely unnecessarily complex considering the current maintenance strategy for the v2 branch.