Merged
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
c9801c5 to
1f9b4ce
Compare
This was referenced Oct 23, 2020
Member
sharwell
reviewed
Oct 23, 2020
Contributor
sharwell
left a comment
There was a problem hiding this comment.
...EditorFeatures/Core.Cocoa/InlineRename/CommandHandlers/RenameCommandHandler_RenameHandler.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Cocoa/Microsoft.CodeAnalysis.EditorFeatures.Cocoa.csproj
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Cocoa/NavigationCommandHandlers/FindBaseSymbolsCommandHandler.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Oct 23, 2020
d79c28b to
b9fdb77
Compare
Member
|
@tmat Just to confirm, I see there's a bunch of files that seem cloned in this PR. I presume the sequence of events was:
Is that correct? |
Member
|
Yes, Cocoa was a fork of EditorFeatures.Wpf which first lived in the VSMac repo, then got moved to the VS-Platform repo (for expediency) and now found it's best home in the Roslyn repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches commit https://devdiv.visualstudio.com/DevDiv/_git/VS-Platform/commit/10204c06cc105f2f2455ae6f84f34eac2ce21c93
Corresponding change in VS-Platform: https://devdiv.visualstudio.com/DevDiv/_git/VS-Platform/pullrequest/283665
Fixes #48866