Make compiler server logging explicit#48557
Merged
jaredpar merged 4 commits intodotnet:masterfrom Nov 20, 2020
Merged
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
Author
|
@roslyn-compiler PTAL |
333fred
reviewed
Oct 20, 2020
333fred
reviewed
Oct 20, 2020
src/Compilers/Server/VBCSCompiler/AnalyzerConsistencyChecker.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@roslyn-compiler PTAL. Sorry, lost track of this PR for a bit but it's updated now to latest. |
Member
Author
|
Sigh .... @dotnet/roslyn-compiler PTAL Apparently I keep @ the wrong alias. |
RikkiGibson
reviewed
Nov 19, 2020
RikkiGibson
reviewed
Nov 19, 2020
Member
There was a problem hiding this comment.
nit: should this be an ICompilerServerLogger?
Member
Author
There was a problem hiding this comment.
In this case the field is unconditionally initialized as XunitCompilerServerLogger hence I decided to keep the field type reflective of that.
RikkiGibson
reviewed
Nov 19, 2020
src/Compilers/Server/VBCSCompilerTests/CompilerServerApiTest.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
reviewed
Nov 19, 2020
src/Compilers/Server/VBCSCompilerTests/VBCSCompilerServerTests.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
reviewed
Nov 19, 2020
src/Compilers/Server/VBCSCompilerTests/VBCSCompilerServerTests.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
reviewed
Nov 19, 2020
src/Compilers/Server/VBCSCompilerTests/VBCSCompilerServerTests.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
approved these changes
Nov 19, 2020
Member
RikkiGibson
left a comment
There was a problem hiding this comment.
LGTM aside from a few nits
333fred
approved these changes
Nov 20, 2020
This changes the compiler server logging infrastructure to be an explicit resource vs. an ambient authority. This both cleans up our implementation a bit but also allows us to take advantage of xUnit output logging in our unit tests. The `ITestOutputHelper` can be the implementation of an `ICompilerServerLogger`. This means that when compiler server tests fail we get the full benefit of our logging infrastructure in the test output vs. having to just guess at what failed here.
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 20, 2020
* upstream/master: (47 commits) Make compiler server logging explicit (dotnet#48557) [master] Update dependencies from dotnet/arcade (dotnet#48274) Handle removed project in ExternalErrorDiagnosticUpdateSource Report an error for ref-returning auto-properties declared in an interface. (dotnet#49510) Add usings on paste (dotnet#48501) Determinism test needs to use bootstrap compiler (dotnet#49483) Simplify and reduce amount of work performed by SourcePropertySymbolBase constructor. (dotnet#49360) Updates test Simplify Split Document/Workspace handler into only handling open/closed documents respectively. only report watson once. Additional usage of a PooledHashset. (dotnet#49459) Loc checkin Update src/Features/CSharp/Portable/CodeRefactorings/ConvertLocalFunctionToMethod/CSharpConvertLocalFunctionToMethodCodeRefactoringProvider.cs Preserve annotation on comment trivia when performing formatting. Validate arguments to IAsyncCompletionSource methods Determinism fixes for AnonymousTypes in VB (dotnet#49467) Collect nfw information for a crash we're seeing. Make sure to not discard text changes when no reference changes are present Create an unsafe method from a local function when necessary (dotnet#49389) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the compiler server logging infrastructure to be an
explicit resource vs. an ambient authority. This both cleans up our
implementation a bit but also allows us to take advantage of xUnit
output logging in our unit tests.
The
ITestOutputHelpercan be the implementation of anICompilerServerLogger. This means that when compiler server tests failwe get the full benefit of our logging infrastructure in the test
output vs. having to just guess at what failed here.