Skip to content

Merge release/dev16.8 to release/dev16.8-vs-deps#48550

Merged
JoeRobich merged 2 commits intorelease/dev16.8-vs-depsfrom
merges/release/dev16.8-to-release/dev16.8-vs-deps
Oct 14, 2020
Merged

Merge release/dev16.8 to release/dev16.8-vs-deps#48550
JoeRobich merged 2 commits intorelease/dev16.8-vs-depsfrom
merges/release/dev16.8-to-release/dev16.8-vs-deps

Conversation

@dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from release/dev16.8 into release/dev16.8-vs-deps.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/release/dev16.8-to-release/dev16.8-vs-deps
git reset --hard upstream/release/dev16.8-vs-deps
git merge upstream/release/dev16.8
# Fix merge conflicts
git commit
git push upstream merges/release/dev16.8-to-release/dev16.8-vs-deps --force

@ghost
Copy link

ghost commented Oct 13, 2020

Hello @dotnet-bot!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@Cosifne
Copy link
Member

Cosifne commented Oct 14, 2020

@JoeRobich
https://dev.azure.com/dnceng/public/_build/results?buildId=850271&view=logs&j=1b62957c-5a36-5ed5-0b29-aaee9f9b9f82&t=5a72ceaa-4eec-5a0d-894d-8a9ba5d33977&l=127

Could you check it?
(It is complaining about a method can't be found. How could that pass the CI?)

@JoeRobich
Copy link
Member

JoeRobich commented Oct 14, 2020

This is another case of GH linking to the wrong run of CI. Here is the proper (passing) CI runs:
integration CI for this PR - https://dev.azure.com/dnceng/public/_build/results?buildId=850274&view=results
CI for this PR - https://dev.azure.com/dnceng/public/_build/results?buildId=850273&view=results

This should be good to merge.

@JoeRobich JoeRobich merged commit e0d0c92 into release/dev16.8-vs-deps Oct 14, 2020
@dotnet-bot dotnet-bot deleted the merges/release/dev16.8-to-release/dev16.8-vs-deps branch October 14, 2020 21:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.8-to-release/dev16.8-vs-deps branch October 15, 2020 00:03
@dotnet-bot dotnet-bot deleted the merges/release/dev16.8-to-release/dev16.8-vs-deps branch October 15, 2020 00:03
@dotnet-bot dotnet-bot restored the merges/release/dev16.8-to-release/dev16.8-vs-deps branch October 15, 2020 03:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.8-to-release/dev16.8-vs-deps branch October 15, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants